Fix failing sample run #41
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Prevent error when running run_all_samples.sh
Contributor
|
The way to run the failed sample looks like too specific. It is not a good way. In addition, new samples may need to interact with the user... Therefore, I think the better way is do not run the samples when packing the software. |
VincentWei
approved these changes
Dec 7, 2022
Contributor
VincentWei
left a comment
VincentWei
left a comment
There was a problem hiding this comment.
This change is ok! Thanks a lot.
VincentWei
requested changes
Dec 7, 2022
Contributor
VincentWei
left a comment
VincentWei
left a comment
There was a problem hiding this comment.
Not a good way to specify the arguments when running a sample. We can consider to exclude a group of samples which will not be run automatically in the script run_all_samples.sh, especially ones interacting with the user.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addressing failure
Source/Samples/DOMRuler/layout_html/layout_html
in
#40