Skip to content

Fix GPU Memory Leak in GLTF Geometry Import #792

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
remo-lab wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Fix GPU Memory Leak in GLTF Geometry Import #792

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 9 additions & 4 deletions packages/phoenix-event-display/src/managers/three-manager/import-manager.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -436,12 +436,17 @@ export class ImportManager {
// Improve renderorder for transparent materials
scene.remove(...scene.children);
for (const val of Object.values(materials)) {
const mesh = new Mesh(
BufferGeometryUtils.mergeGeometries((val as any).geoms),
(val as any).material,
);
const intermediateGeoms = (val as any).geoms;
const mergedGeometry =
BufferGeometryUtils.mergeGeometries(intermediateGeoms);
const mesh = new Mesh(mergedGeometry, (val as any).material);
mesh.renderOrder = (val as any).renderOrder;
scene.add(mesh);

// Dispose intermediate geometries to free GPU memory
for (const geom of intermediateGeoms) {
geom.dispose();
}
}

this.processGeometry(
Expand Down