chore: unify packaging metadata, set Apache-2.0, add packaging CI#294
Open
DhanashreePetare wants to merge 1 commit intoHSF:masterfrom
Open
chore: unify packaging metadata, set Apache-2.0, add packaging CI#294DhanashreePetare wants to merge 1 commit intoHSF:masterfrom
DhanashreePetare wants to merge 1 commit intoHSF:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
Align packaging metadata so pyproject.toml is the canonical source of truth, unify license to Apache-2.0, update Python requirement to >=3.8, and add a CI workflow to validate built package metadata during PRs.
Changes:
Updated pyproject.toml (added requires-python + classifiers), updated setup.py to mirror metadata, added packaging note to README.md, and added GitHub Actions workflow at .github/workflows/validate-packaging.yml.
Why: Current repository had conflicting license and Python-support fields between pyproject.toml and setup.py, which causes legal/tooling ambiguity and can lead to incorrect metadata being published.
Verification:
Build the package and inspect METADATA locally:
python -m pip install --upgrade pip build
python -m build
unzip -p dist/.whl '/METADATA' > METADATA && grep -E 'License:|Requires-Python:' METADATA
Notes for reviewers:
If the project intends a different license (e.g., GPL), please confirm and I will update pyproject.toml and LICENSE accordingly. After merge we can simplify or remove setup.py once maintainers are comfortable with pyproject.toml as authoritative.