Skip to content

Fix typo and improve FIXME comment in core_utils.py #292

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mightqxc merged 1 commit into from
Dec 4, 2025
Merged

Fix typo and improve FIXME comment in core_utils.py #292

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions pandaharvester/harvestercore/core_utils.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -402,7 +402,7 @@ def update_job_attributes_with_workers(map_type, jobspec_list, workspec_list, fi
for workSpec in workspec_list:
if workSpec.new_status:
jobSpec.trigger_propagation()
# the the worker is running
# the worker is running
if workSpec.status in [WorkSpec.ST_running]:
isRunning = True
# set start time
Expand Down Expand Up @@ -435,7 +435,9 @@ def update_job_attributes_with_workers(map_type, jobspec_list, workspec_list, fi
# live core count
jobSpec.nCore = nCore
# combine worker attributes and set it to job
# FIXME
# NOTE: Setting worker attributes is commented out for MultiWorkers map type
# as it requires aggregating attributes from multiple workers, which needs
# careful implementation to avoid conflicts
# jobSpec.set_attributes(workAttributes)
# add files
outFileAttrs = jobSpec.get_output_file_attributes()
Expand Down