Remove outdated FIXME comment in job_spec.py#291
Closed
Rudra-Tiwari-codes wants to merge 3 commits intoHSF:masterfrom
Closed
Remove outdated FIXME comment in job_spec.py#291Rudra-Tiwari-codes wants to merge 3 commits intoHSF:masterfrom
Rudra-Tiwari-codes wants to merge 3 commits intoHSF:masterfrom
Conversation
Add comprehensive docstrings to zip_output, async_zip_output, and post_zip_output methods in SimpleZipper and SshZipper classes to match the documentation style used in DummyZipper. This improves code maintainability and API documentation consistency.
Enhance error handling in check_workers method to properly catch and handle HTTPError, RequestException, and JSON parsing errors. Add explicit raise_for_status call and improve error messages with proper logging. Add validation for response data structure before accessing nested fields. Add warning log for unknown batch status values.
Remove FIXME comment about Python 2.7 set literal usage as Python 2.7 has been end of life since 2020. The current dictionary implementation is correct and appropriate for the use case.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR removes an outdated FIXME comment about Python 2.7 set literal usage. Python 2.7 has been end of life since 2020, and the current dictionary implementation is correct and appropriate for the use case.