-
Notifications
You must be signed in to change notification settings - Fork 26
feat: change default width to 90 rem #409
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Summary of ChangesHello @kowyo, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request broadens the default content display area by adjusting the page and footer widths to Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
Deploying hoa-moe with
|
| Latest commit: |
e990e75
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://6627578a.hitsz-open-auto-github-io.pages.dev |
| Branch Preview URL: | https://feat-default-width.hitsz-open-auto-github-io.pages.dev |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request updates the default page width from 80rem to 90rem. The changes are consistently applied across the configuration, JavaScript, and HTML partials. A new icon is also introduced for the width switcher. My main concern is the removal of the logic that prevented width transitions on initial page load. This may introduce an undesirable animation or layout shift when a page first renders. I've left a specific comment with more details.
| applyWidth(isFull); | ||
| setTimeout(() => root.classList.remove("hoa-width-no-transition"), 0); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The logic to prevent width transitions on initial page load has been removed from both this file and assets/css/custom.css. This will likely cause an unwanted animation or layout shift when a page is first loaded.
The previous implementation, which used the hoa-width-no-transition class to temporarily disable transitions, is a standard technique to ensure a smooth initial render. Unless this was an intentional change, I'd recommend restoring this logic to avoid a visual glitch for users.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No issues found across 5 files
No description provided.