Widget Mode, Mute Other apps on adhan play, always on top, Update checker #34

abdofallah · 2025-02-08T10:41:18Z

Optimize:

Organize classes better

Added:

Full size vs Small Size
mute all other apps when adhan is playing
always on top
update popup if versions do not match with git release (make sure the git release tag follows the same structure as now = starts with V and then version number)

Preview:

- Organize classes better Added: - Implement Full size vs Small Size - Implement mute all other apps when adhan is playing Todo: - Implement always on top

… yes opens the browser and starts the download (currently installation is done manually by user)

this should kill the already running openadhan app when installer is ran

…roject is used)

…f this project is used)" This reverts commit 34b2ec6.

iysaleh · 2025-02-10T03:56:32Z

MashaaAllah brother, I'm only looking at screenshots right now, but I love this!!!!!! I can't believe you implemented the updater/version-checker feature!!!! 😁 !!!!! And this minified mode of the app display is also very neat. JazzakAllahukhayr!

I'm a bit busy right now so it'll likely be a few days before I get to properly reviewing this, but just know I'm not ignoring it.

Looking forward to getting this merged in inshaaAllah!!!! 😄
-Ibraheem

abdofallah · 2025-02-10T11:41:13Z

MashaaAllah brother, I'm only looking at screenshots right now, but I love this!!!!!! I can't believe you implemented the updater/version-checker feature!!!! 😁 !!!!! And this minified mode of the app display is also very neat. JazzakAllahukhayr!

I'm a bit busy right now so it'll likely be a few days before I get to properly reviewing this, but just know I'm not ignoring it.

Looking forward to getting this merged in inshaaAllah!!!! 😄 -Ibraheem

All good brother take your time.

abdofallah · 2025-03-08T11:48:28Z

^

iysaleh

Overall this looks very nice, great refactors and good new features...

There are just few problems that need to be addressed before this can be merged:

Looks like the unit tests & RegistrySettingsHandler app fails to install:

Just as an FYI, the purpose of the RegistrySettingsHandler application is to install the registry keys as administrator when the app is first installed on a new computer -- It also opens the permissions for those keys so the OpenAdhan app can modify/update them as users please without admin privileges.

Also, maybe I'm wrong here, but is the small-mode/normal-mode toggle button a little brighter than the rest of the white used in the app? It feels distracting, can you please make it darker/greyer so it doesn't steal focus?

Sorry about the super late review -- things have been super busy here. Ramadan Mubarak!!!! 😄

iysaleh · 2025-03-09T22:02:20Z

OpenAdhanForWindowsX/Managers/RegistrySettingsHandler.cs

                    SaveRegistryValue(automaticDaylightSavingsAdjustmentKey, "0", "int");
                SaveRegistryValue(normalAdhanFilePathkey, oass.normalAdhanFilePath, "string");
                SaveRegistryValue(fajrAdhanFilePathKey, oass.fajrAdhanFilePath, "string");
+                SaveRegistryValue(muteAllAppsOnAdhanPlayingKey, oass.muteAllAppsOnAdhanPlaying ? "1" : "0", "int");


Let's turn this off by default -- The adhan often plays in the middle of important work happening, including meetings that people are having-- muting the meeting/work fully is likely undesired default behavior.

iysaleh · 2025-03-09T22:02:50Z

OpenAdhanForWindowsX/Forms/MainAppForm.cs

+                nextPrayerLabel.BackColor = Color.Transparent;
+                nextPrayerNameLabel.BackColor = Color.Transparent;
+                nextPrayerInLabel.BackColor = Color.Transparent;
+                nextPrayerInTimeLabel.BackColor = Color.Transparent;


Nice, the label renames here should make things clearer.

iysaleh · 2025-03-09T22:04:29Z

OpenAdhanForWindowsX/Managers/TaskScheduler.cs

+            this.timers.RemoveRange(0, this.timers.Count);
+        }
+    }
+}


👍 nice refactor

iysaleh · 2025-03-09T22:20:42Z

OpenAdhanForWindowsX/Program.cs

-            //System.Diagnostics.Debug.WriteLine("RSH CalcMethod: " + calcMethod);
-            //System.Diagnostics.Debug.WriteLine("RSH JuristicMethod: " + juristicMethod);
-            //System.Diagnostics.Debug.WriteLine("RSH Lat: " + lat);
-            //System.Diagnostics.Debug.WriteLine("RSH Lon: " + lon);
-            //System.Diagnostics.Debug.WriteLine("RSH TZ: " + tz);
-            //System.Diagnostics.Debug.WriteLine("RSH Date is DST: " + TimeZoneInfo.Local.IsDaylightSavingTime(cc));
+               string jsonString = await response.Content.ReadAsStringAsync();

+                string searchTagName = "\"tag_name\":";
+                int tagNameIndex = jsonString.IndexOf(searchTagName);

-            String[] prayer_times_strings = p.getDatePrayerTimes(y, m, d, lon, lat, tz);
-            // This only returns HH:MM -- all date info is lost.
-
-            //System.Diagnostics.Debug.WriteLine("PrayTimes Fajr: " + prayer_times_strings[fajr]);  
-
-            double daylightSavingsTimeAdjustment = 0.0;
-            if (autoDst)
-            {
-                if (TimeZoneInfo.Local.IsDaylightSavingTime(cc))
+                if (tagNameIndex != -1)
                {
-                    daylightSavingsTimeAdjustment = +60.0;
-                }
-            }
+                    int start = tagNameIndex + searchTagName.Length;
+                    int end = jsonString.IndexOf(",", start);

-            // if specific date isn't null (IE, not calculating for today):
-            if (specificDate != null)
-            {
-                prayer_times_strings[fajr] = cc.Date.ToShortDateString() + " " + prayer_times_strings[fajr];
-                prayer_times_strings[shurook] = cc.Date.ToShortDateString() + " " + prayer_times_strings[shurook];
-                prayer_times_strings[dhuhr] = cc.Date.ToShortDateString() + " " + prayer_times_strings[dhuhr];
-                prayer_times_strings[asr] = cc.Date.ToShortDateString() + " " + prayer_times_strings[asr];
-                prayer_times_strings[sunset] = cc.Date.ToShortDateString() + " " + prayer_times_strings[sunset];
-                prayer_times_strings[maghrib] = cc.Date.ToShortDateString() + " " + prayer_times_strings[maghrib];
-                prayer_times_strings[isha] = cc.Date.ToShortDateString() + " " + prayer_times_strings[isha];
-            }
+                    string latestVersion = jsonString.ToLower().Substring(start, end - start).Trim('"').Trim('v');

-            // Parse DateTimes
-            this.prayer_datetimes = new DateTime[7];
-            try
-            {
-                this.prayer_datetimes[fajr] = DateTime.Parse(prayer_times_strings[fajr]).AddMinutes(this.rsh.SafeLoadFloatRegistryValue(RegistrySettingsHandler.fajrAdjustmentKey)).AddMinutes(daylightSavingsTimeAdjustment);
-                this.prayer_datetimes[shurook] = DateTime.Parse(prayer_times_strings[shurook]).AddMinutes(this.rsh.SafeLoadFloatRegistryValue(RegistrySettingsHandler.shurookAdjustmentKey)).AddMinutes(daylightSavingsTimeAdjustment);
-                this.prayer_datetimes[dhuhr] = DateTime.Parse(prayer_times_strings[dhuhr]).AddMinutes(this.rsh.SafeLoadFloatRegistryValue(RegistrySettingsHandler.dhuhrAdjustmentKey)).AddMinutes(daylightSavingsTimeAdjustment);
-                this.prayer_datetimes[asr] = DateTime.Parse(prayer_times_strings[asr]).AddMinutes(this.rsh.SafeLoadFloatRegistryValue(RegistrySettingsHandler.asrAdjustmentKey)).AddMinutes(daylightSavingsTimeAdjustment);
-                this.prayer_datetimes[sunset] = DateTime.Parse(prayer_times_strings[sunset]).AddMinutes(daylightSavingsTimeAdjustment);
-                this.prayer_datetimes[maghrib] = DateTime.Parse(prayer_times_strings[maghrib]).AddMinutes(this.rsh.SafeLoadFloatRegistryValue(RegistrySettingsHandler.maghribAdjustmentKey)).AddMinutes(daylightSavingsTimeAdjustment);
-                this.prayer_datetimes[isha] = DateTime.Parse(prayer_times_strings[isha]).AddMinutes(this.rsh.SafeLoadFloatRegistryValue(RegistrySettingsHandler.ishaAdjustmentKey)).AddMinutes(daylightSavingsTimeAdjustment);
+                    if (latestVersion != currentVersion)
+                    {
+                        string message = "A new version of OpenAdhan is available.\n\n" +
+                            "Current Version: " + currentVersion + "\n" +
+                            "Latest Version: " + latestVersion + "\n\n" +
+                            "Would you like to update now?";
+
+                        if (MessageBox.Show(message, "OpenAdhan", MessageBoxButtons.YesNo, MessageBoxIcon.Question) == DialogResult.Yes)
+                        {
+                            System.Diagnostics.Process.Start("https://github.com/HICalSoft/OpenAdhan/releases/download/V" + latestVersion + "/OpenAdhanInstaller.exe");
+                        }


Awesome! 😄

Not quite full auto-updating just yet, but atleast the user knows there's a new version that should probably be downloaded.

iysaleh · 2025-03-09T22:32:11Z

Btw, don't you think it looks better with the sun in front of the timeline? (the top one, what we had before these changes) @abdofallah

abdofallah · 2025-03-13T12:25:12Z

Overall this looks very nice, great refactors and good new features...

There are just few problems that need to be addressed before this can be merged:

Looks like the unit tests & RegistrySettingsHandler app fails to install:

Just as an FYI, the purpose of the RegistrySettingsHandler application is to install the registry keys as administrator when the app is first installed on a new computer -- It also opens the permissions for those keys so the OpenAdhan app can modify/update them as users please without admin privileges.

Also, maybe I'm wrong here, but is the small-mode/normal-mode toggle button a little brighter than the rest of the white used in the app? It feels distracting, can you please make it darker/greyer so it doesn't steal focus?

Sorry about the super late review -- things have been super busy here. Ramadan Mubarak!!!! 😄

No worries! Ramadan Mubarak to you as well.

I noticed RegistrySettingsHandler was being used and fixed it back so it should work as expected.

Still not used to having tests in my application so xD let me check what is causing them to fail.

The toggle button seems to have same contract as prayer labels so yeah makes sense to make it darker.

sure we can turn muteAllAppsOnAdhanPlaying off by default and maybe have application exclusion list when the settings page is revamped as well.

We could try to implement a complete installation feature somehow as well but it will require run as admin or etc permissions.

abdofallah · 2025-03-13T12:25:55Z

Btw, don't you think it looks better with the sun in front of the timeline? (the top one, what we had before these changes) @abdofallah

as that is weird...

for me the line is below the sun:

iysaleh · 2025-03-13T13:43:16Z

Btw, don't you think it looks better with the sun in front of the timeline? (the top one, what we had before these changes) @abdofallah

as that is weird...

for me the line is below the sun:

Hmm, I thought that maybe it's because I'm on a new Windows 11 computer now (was previously building on Windows 10) --- but I just built the main branch on my Windows 11 computer and the sun is in front of the line as expected --- it only goes behind the line on this branch... Something must have changed I think.

abdofallah added 3 commits February 8, 2025 14:40

Optimize:

2fe79ae

- Organize classes better Added: - Implement Full size vs Small Size - Implement mute all other apps when adhan is playing Todo: - Implement always on top

Implement always on top functionality

c825730

Implement a basic update check based on github release tags, clicking…

dd1e8cc

… yes opens the browser and starts the download (currently installation is done manually by user)

abdofallah changed the title ~~Widget Mode, Mute Other apps on adhan play, always on top~~ Widget Mode, Mute Other apps on adhan play, always on top, Update checker Feb 8, 2025

abdofallah added 4 commits February 8, 2025 15:48

UNTESTED

25af598

this should kill the already running openadhan app when installer is ran

Fix registry handler in OpenAdhanRegistrySetupApp (not sure if this p…

34b2ec6

…roject is used)

Revert "Fix registry handler in OpenAdhanRegistrySetupApp (not sure i…

e0c5106

…f this project is used)" This reverts commit 34b2ec6.

Fix registry handler in OpenAdhanRegistrySetupApp

c066c80

iysaleh reviewed Mar 9, 2025

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Widget Mode, Mute Other apps on adhan play, always on top, Update checker #34

Widget Mode, Mute Other apps on adhan play, always on top, Update checker #34

Uh oh!

abdofallah commented Feb 8, 2025 •

edited

Loading

Uh oh!

iysaleh commented Feb 10, 2025 •

edited

Loading

Uh oh!

abdofallah commented Feb 10, 2025

Uh oh!

abdofallah commented Mar 8, 2025

Uh oh!

iysaleh left a comment

Uh oh!

iysaleh Mar 9, 2025 •

edited

Loading

Uh oh!

iysaleh Mar 9, 2025

Uh oh!

iysaleh Mar 9, 2025

Uh oh!

iysaleh Mar 9, 2025

Uh oh!

iysaleh commented Mar 9, 2025 •

edited

Loading

Uh oh!

abdofallah commented Mar 13, 2025

Uh oh!

abdofallah commented Mar 13, 2025

Uh oh!

iysaleh commented Mar 13, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Widget Mode, Mute Other apps on adhan play, always on top, Update checker #34

Are you sure you want to change the base?

Widget Mode, Mute Other apps on adhan play, always on top, Update checker #34

Uh oh!

Conversation

abdofallah commented Feb 8, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

iysaleh commented Feb 10, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

abdofallah commented Feb 10, 2025

Uh oh!

abdofallah commented Mar 8, 2025

Uh oh!

iysaleh left a comment

Choose a reason for hiding this comment

Uh oh!

iysaleh Mar 9, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

iysaleh Mar 9, 2025

Choose a reason for hiding this comment

Uh oh!

iysaleh Mar 9, 2025

Choose a reason for hiding this comment

Uh oh!

iysaleh Mar 9, 2025

Choose a reason for hiding this comment

Uh oh!

iysaleh commented Mar 9, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

abdofallah commented Mar 13, 2025

Uh oh!

abdofallah commented Mar 13, 2025

Uh oh!

iysaleh commented Mar 13, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

abdofallah commented Feb 8, 2025 •

edited

Loading

iysaleh commented Feb 10, 2025 •

edited

Loading

iysaleh Mar 9, 2025 •

edited

Loading

iysaleh commented Mar 9, 2025 •

edited

Loading