feat: offset pagination #1
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
francesconi
force-pushed
the
offset-pagination
branch
from
dc30438 to
b678269
Compare
davidspiess
reviewed
Dec 2, 2024
| Option[T any] func(*Paginator[T]) | ||
| ) | ||
|
|
||
| func New[T any](page, pageSize int, opts ...Option[T]) Paginator[T] { |
Member
There was a problem hiding this comment.
I would opt for passing the whole struct on initialisation, it's easy to missplace page and pageSize, which both are integers.
| ) | ||
|
|
||
| const ( | ||
| defaultPageSize int = 100 |
Member
There was a problem hiding this comment.
I personally would reduce the default page sitze to 50.
Auth0 does this.
davidspiess
reviewed
Dec 3, 2024
|
|
||
| func Parse[T any](r *http.Request, opts ...Option[T]) Paginator[T] { | ||
| q := r.URL.Query() | ||
| page, _ := strconv.Atoi(q.Get("page")) |
Member
There was a problem hiding this comment.
I don't like the approach of swallowing parsing errors
davidspiess
reviewed
Dec 10, 2024
| } | ||
| Result[T any] struct { | ||
| Items []T `json:"items"` | ||
| NextPage *int `json:"next_page,omitempty"` |
Member
There was a problem hiding this comment.
I personally would remove the pointer here, since omitempty works with default values too.
francesconi
force-pushed
the
offset-pagination
branch
from
77e4971 to
1ad5f7f
Compare
davidspiess
approved these changes
Jan 2, 2025
stuppner
approved these changes
Jan 2, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some guidelines were taken from https://google.aip.dev/158.