Skip to content

Feature docker local env#23

Open
jasongauvin wants to merge 3 commits intomainfrom
feature-docker-local-env
Open

Feature docker local env#23
jasongauvin wants to merge 3 commits intomainfrom
feature-docker-local-env

Conversation

@jasongauvin
Copy link
Collaborator

Summary

Description

This PR init the project with docker, Makefile and update the README.md and CONTRIBUTING.md

Related Issue

Motivation and Context

Types of changes

  • Docs change / refactoring / dependency upgrade
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.

@jasongauvin jasongauvin added documentation Improvements or additions to documentation feature New feature or request labels Jul 12, 2021

The convention is to prefix the branch name with feature-. All the words must be separated by a -.

Branch name example : feature-user-authentication No newline at end of file

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pour les noms de branch je proposerais plus un "/" après le type de branch (feature, fix etc.)
A voir l'avis général

Ex: feature/user-authentication

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same for me i prefer the naming convention with "/"

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Moi ça me va si tout le monde est d'accord :)

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Et pour la séparation des mots - ou _ ?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"-"

@Akecel Akecel removed their request for review February 23, 2022 12:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Improvements or additions to documentation feature New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants