Clarify a comment regarding ffflus #115
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ffflus (on *-nix) eventually calls fflush. It does *not* call fsync or sync, and the data may not be on they physical device after this function returns. This change clarifies the comment to emphasize that.
Contributor
|
Instead of changing a bunch of comments, maybe it should just call fsync since that seems to be the intention? |
Contributor
Author
|
Perhaps calling fsync is the right thing to do, but I'm certainly not familiar enough with the code yet to make such a change! At the moment, I just want comments that aren't misleading. Calling fsync could have substantial performance penalties for users of the library, and I don't think there is enough of a benchmark in place to be able to understand what the impact would be. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ffflus (on *-nix) eventually calls fflush. It does not call fsync or sync, and the data may not be on they physical device after this function returns. This change clarifies the comment to emphasize that.