Skip to content

Conversation

@mattjala
Copy link
Contributor

@mattjala mattjala commented Jun 30, 2025

  • Replace deprecated unixsocket dependency with a fork that is still maintained

The original package is incompatible with requests 2.32.0+.


Important

Replace deprecated requests-unixsocket with requests-unixsocket2 and update related dependencies for compatibility with requests 2.32.0+.

  • Dependencies:
    • Replace requests-unixsocket with requests-unixsocket2 in Pipfile, pyproject.toml, and requirements.txt.
    • Update requests version constraint to <=2.32.4 in Pipfile, pyproject.toml, and requirements.txt.
    • Update urllib3 version constraint to >=2.4.0,<3.0 in Pipfile, pyproject.toml, and requirements.txt.
    • Relax aiobotocore version constraint to >=2.13.0 in Pipfile, pyproject.toml, and requirements.txt.
  • CI/CD:
    • Remove commented-out step for fixing requests version in .github/workflows/python-package.yml.

This description was created by Ellipsis for c071fa4. You can customize this summary. It will automatically update as commits are pushed.

@mattjala mattjala self-assigned this Jun 30, 2025
@mattjala mattjala added the dependencies Pull requests that update a dependency file label Jun 30, 2025
@mattjala
Copy link
Contributor Author

Botocore and the replacement for unixsocket have an unavoidable dependency conflict for Python 3.9. Options for resolving this are to drop support for Python 3.9, freeze requests/urllib/requests-unixsocket at their current version, or replace requests-unixsocket with something else

@jreadey
Copy link
Member

jreadey commented Jul 1, 2025

I'd vote to drop support for Unix Sockets. Originally I was thinking that this might be a performance enhancement for clients and servers on the same host, but it's marginal if anything. Also, I think there can be problems when two clients are using the same socket connection.

If we go this way, the ruanll.sh script should change the --no-docker option to use TCP rather than sockets.

@jreadey
Copy link
Member

jreadey commented Aug 15, 2025

Actually we use unix sockets in hsds_app.py, and I prefer not to update the code to use tcp sockets.
Let's go with changing the unix-socket to use the gitlab project.

Copy link
Member

@jreadey jreadey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's go with this. I'll submit a PR to remove Python 3.9 support

@jreadey jreadey marked this pull request as ready for review August 19, 2025 09:54
@jreadey jreadey merged commit e36464c into HDFGroup:master Aug 19, 2025
23 of 29 checks passed
@mattjala mattjala mentioned this pull request Aug 19, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dependencies Pull requests that update a dependency file

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants