HPHX-15373 Localization for Hikes Catalog by honlamso · Pull Request #138 · HCL-TECH-SOFTWARE/volt-mx-tutorials

honlamso · 2022-03-04T09:49:56Z

Description

This PR enables i18n for Hikes Catalog
Note that the hike zip files have not been converted to localizable format yet

Technical documentations can be found here:
https://hclo365.sharepoint.com/:w:/s/PMO-GCG-All-Hikesdevelopment/ESGYIZdAP6ZGt2UvYlXIHH0BZKtXUClL8zLVWOoJJhU7FQ?e=AeFmb4

Type of change

Bug fix (non-breaking change which fixes an issue)
New feature (non-breaking change which adds functionality)
Breaking change (fix or feature that would cause existing functionality to not work as expected)
This change requires a documentation update

…x-tutorials into localization-enabelment

…nabelment enable catalog server localization

update translated tours jsons

set to phx-dev

# Conflicts: # .github/workflows/intergrate.yml # next.config.js # pages/hikes.js # pages/tour.js # public/contents/1-volt-mx-changes/tours.json # public/contents/1-volt-mx-changes/zips/voltmxirisintro.zip # public/contents/2-build-your-first-mobile-app/tours.json # public/contents/2-build-your-first-mobile-app/zips/addcreatemob_v9.zip # public/contents/2-build-your-first-mobile-app/zips/addloginservicemob_v9.zip # public/contents/2-build-your-first-mobile-app/zips/connectappuitodatamob_v9.zip # public/contents/2-build-your-first-mobile-app/zips/createdetailsnative_v9.zip # public/contents/2-build-your-first-mobile-app/zips/createservices_v9.zip # public/contents/2-build-your-first-mobile-app/zips/createuifromcollectionsmob_v9.zip # public/contents/2-build-your-first-mobile-app/zips/editpayeemobile_v9.zip # public/contents/2-build-your-first-mobile-app/zips/launchyourfirstmobileappv92.zip # public/contents/2-build-your-first-mobile-app/zips/pubishappenterprisestorev9.zip # public/contents/2-build-your-first-mobile-app/zips/shareandpreviewappmobilev9.zip # public/contents/2-build-your-first-mobile-app/zips/usingtestrecorder_v9.zip # public/contents/3-build-your-first-web-app/tours.json # public/contents/3-build-your-first-web-app/zips/addauthenticationtoyourapp_v9.zip # public/contents/3-build-your-first-web-app/zips/addcreatepayeeweb_v9.zip # public/contents/3-build-your-first-web-app/zips/connecttheappuitodata-webv9.zip # public/contents/3-build-your-first-web-app/zips/createdetailsscreen_v9.zip # public/contents/3-build-your-first-web-app/zips/createservicesweb_v9.zip # public/contents/3-build-your-first-web-app/zips/createuifromcollections-web.zip # public/contents/3-build-your-first-web-app/zips/editpayeeweb_v9.zip # public/contents/3-build-your-first-web-app/zips/launchyourrwapp92.zip # public/contents/3-build-your-first-web-app/zips/responsivewebbreakpointsv9.zip # public/contents/4-develop-the-front-end/tours.json # public/contents/4-develop-the-front-end/zips/assigndatatothesegmentv9.zip # public/contents/4-develop-the-front-end/zips/createemailidcomponentv9.zip # public/contents/4-develop-the-front-end/zips/flexpropertiesv9.zip # public/contents/4-develop-the-front-end/zips/internationalizationwithlayout92.zip # public/contents/4-develop-the-front-end/zips/introductiontoactioneditorv9.zip # public/contents/4-develop-the-front-end/zips/introductiontointernationalization92.zip # public/contents/4-develop-the-front-end/zips/introductiontokonyjavascriptv9.zip # public/contents/4-develop-the-front-end/zips/introductiontosegmenttemplatesv9.zip # public/contents/4-develop-the-front-end/zips/introductiontosegmentv9.zip # public/contents/4-develop-the-front-end/zips/introflexlayoutv9.zip # public/contents/4-develop-the-front-end/zips/konyquantumorientationv9.zip # public/contents/4-develop-the-front-end/zips/understandingapplicationchannelsv9.zip # public/contents/5-manage-back-end-services/tours.json # public/contents/5-manage-back-end-services/zips/addasalesforceservicev9.zip # public/contents/5-manage-back-end-services/zips/understandidentityservicesv9.zip # public/contents/5-manage-back-end-services/zips/userrepositoryauthenticationv9.zip # public/contents/5-manage-back-end-services/zips/usesampleservicesv9.zip # public/contents/5-manage-back-end-services/zips/usestorageservicev9.zip # public/contents/6-advanced-concepts/tours.json # public/contents/6-advanced-concepts/zips/introductiontonfiv9.zip # public/contents/6-advanced-concepts/zips/nfibarcodev9.zip # public/contents/7-dbx/tours.json # public/contents/7-dbx/zips/dynamicform.zip # src/components/HikeHeader/index.js # src/components/TourCard/index.js # src/utils/populate.js

Merge latest phx-dev to l10n

…utorials into fix-empty-router-query

…er-query Fix continues loading in gh pages env

mandeepalluru · 2022-05-25T16:44:05Z

      const URL = !isDev ? BASE_PATH_URL : '';
-      const searchUrl = `${URL}/hikes/search?keyword=${searchTerm}`;
+      const params = new URLSearchParams({
+        ...Router.params,


I think this should be ...Router.query

mandeepalluru · 2022-05-25T16:45:04Z

-      const searchUrl = `${URL}/hikes/search?keyword=${searchTerm}`;
+      const params = new URLSearchParams({
+        ...Router.params,
+        keyword: searchTerm,


Minor suggestion: The , at the end of "searchTerm" can be omitted.

This repo has eslint enabled with airbnb's rules, which enforces trailing commas:
https://github.com/airbnb/javascript#commas
https://eslint.org/docs/rules/comma-dangle

mandeepalluru · 2022-05-30T17:56:10Z

 export const BASE_BRANCH = 'master';

-export const HOST_URL = `https://opensource.hcltechsw.com`;
+export const HOST_URL = `https://honlamso.github.io`;


I think changes in this file were for testing purpose. We can revert them.

yes, thanks for pointing out

mandeepalluru · 2022-05-31T17:53:57Z

-      "_blank"
-    );
-  };
+  // const visitFork = () => {


Please remove the commented code. If it is required for re-enablement in the future please comment and add a TODO statement.

mandeepalluru · 2022-05-31T17:57:00Z

        title={
          pushed
-            ? "Pushed Successfully"
+            ? 'Pushed Successfully'


Minor comment. Certain strings in this file such as here have not been localised.

Components under HikeComposer are not localised currently as it is a separate tool for editing tours, which is not a page seen by users on the catalog

mandeepalluru · 2022-05-31T18:40:18Z

Just a quick check. File package-lock.json has 252 additions and 22,906 deletions. I just wanted to confirm that the changes relate to the new modules added.

mandeepalluru · 2022-05-31T18:54:02Z

-      setPreviewMode("split");
+  const changePreview = (v) => {
+    setView(v);
+    if (visible === 'list') {


I think this should be

if (v === 'list')

mandeepalluru · 2022-05-31T19:17:55Z

      "fileSize": "32.13 KB",
      "fileName": "createuifromcollections-web.zip",
      "fid": 17161,
-      "checksum": "f4a220dcd25447979bc8baec7b9063bfe348cef8b3d738d743025631c11b9c3f",


With fixes made in Hikes, the checksums have to be updated.

I have updated the checksums for tour zips that I changed

honlamso · 2022-06-01T10:00:31Z

I have reset the package.json & package-lock.json and re-run npm install for the new modules again to ensure package-lock.json changes are only related to the new modules

CLAassistant · 2022-09-14T13:15:10Z

Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
5 out of 6 committers have signed the CLA.

✅ testradav
✅ yanji-hcl
✅ mikeangelsilva
✅ honlamso
✅ jkjhcl
❌ honchung-tang
_{You have signed the CLA already but the status is still pending? Let us recheck it.}

Trigger build and deploy

yanji-hcl and others added 30 commits May 26, 2021 14:24

enable catalog server localization

d6e1902

resource json structure

2412835

Merge branch 'phx-dev' of https://github.com/HCL-TECH-SOFTWARE/volt-m…

c7842b4

…x-tutorials into localization-enabelment

another approach

9f9dbd5

revoke unnecessary import

0606551

add hindi

9beb031

Merge branch 'l10n' into localization-enabelment

7c3e029

Merge pull request HCL-TECH-SOFTWARE#13 from yanji-hcl/localization-e…

31b214d

…nabelment enable catalog server localization

update translated tours jsons

890fcea

default redirect to en

044796d

remove dup item

001c142

fix loading in webview

ce65196

Merge pull request HCL-TECH-SOFTWARE#28 from yanji-hcl/translated-tours

ed9030d

update translated tours jsons

set to phx-dev

8643e97

Merge pull request HCL-TECH-SOFTWARE#30 from mikeangelsilva/update

11991e7

set to phx-dev

change to i10n for deploy

0743a1d

rollback

63ea58c

add log before reload

a3e1e40

disable reload

9e5e230

fix continues reloading

3fd054c

revoke typo

9fb24e5

Merge phx-dev

5152bf5

add tours json back

4cd3ab1

Merge pull request HCL-TECH-SOFTWARE#42 from yanji-hcl/l10n

cd874bc

Merge latest phx-dev to l10n

Merge branch 'l10n' of https://github.com/HCL-TECH-SOFTWARE/volt-mx-t…

1630522

…utorials into fix-empty-router-query

get hike content when switch lang

a996b05

Merge pull request HCL-TECH-SOFTWARE#41 from yanji-hcl/fix-empty-rout…

cd00dbf

…er-query Fix continues loading in gh pages env

composer edit category in different locales

9a23c4e

translations

0bf3750

fix url

563880a

mandeepalluru reviewed May 25, 2022

View reviewed changes

honlamso added 5 commits May 26, 2022 18:03

fix search

9253506

Merge branch 'l10n'

4275e94

debug logs

49b1262

fix keyword undefined

d3b548c

attempt to fix search

accfd0e

honlamso requested a review from mandeepalluru May 30, 2022 10:04

mandeepalluru reviewed May 30, 2022

View reviewed changes

revert debug changes

525636b

honlamso requested a review from mandeepalluru May 31, 2022 06:07

mandeepalluru reviewed May 31, 2022

View reviewed changes

honlamso added 2 commits June 1, 2022 17:36

fix changePreview logic, remove commented code

c52f525

dependencies update

f2a12be

honlamso requested a review from mandeepalluru June 1, 2022 10:00

Update README.md

4b2d52e

honchung-tang and others added 7 commits September 14, 2022 21:15

Update README.md

ff5013c

Update hikes content from master

33049e0

Update README.md

5ea5626

Trigger build and deploy

Update intergrate.yml

c1d7010

Update environment config for testing

6d5c5f9

Merge branch 'l10n' of github.com:honlamso/volt-mx-tutorials into l10n

845bd37

HPHX-22709 - Fix the symbol

ea23002

Conversation

honlamso commented Mar 4, 2022

Description

Type of change

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

mandeepalluru commented May 31, 2022

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

honlamso commented Jun 1, 2022

Uh oh!

CLAassistant commented Sep 14, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

8 participants

CLAassistant commented Sep 14, 2022 •

edited

Loading