-
Notifications
You must be signed in to change notification settings - Fork 5
Feature/textual gui #79
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
htwangtw
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Amazing, some small tweaks
requirements.txt
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can yoy integrate these into the pyproject.toml? Python is gradually moving to have all the configurations integrated in one file
Co-authored-by: Hao-Ting Wang <htwangtw@gmail.com>
|
merged requested tweaks and moved dependancies to .toml instead of requirements.txt. GUI stack can be downloaded with pip install .[textual] |
htwangtw
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Okay, the test is still failing - we need to have a condition to check if the relevant package is installed before the imports. We can have a look at this:
Nilearn has similar checks for matplotlib:
https://github.com/nilearn/nilearn/blob/73f30611318b3586ae155b086d075f8a80abfabd/nilearn/_utils/helpers.py#L294-L316
And it is used in their conftest to determine whether the test requires a given package.
We can wait until the new year for this one
This PR corresponds to files for the new textual UI.
To use the new UI, please run pip install -r requirements.txt
then pip install -e .
then wonkyconn --textual