-
Notifications
You must be signed in to change notification settings - Fork 3
[ 코드리뷰용 pr ] typescript로 마이그레이션 #20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
5wintaek
wants to merge
35
commits into
5wintaek/ts-refactor
Choose a base branch
from
5wintaek/my-refactor
base: 5wintaek/ts-refactor
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
35 commits
Select commit
Hold shift + click to select a range
4072a7b
Merge pull request #19 from Gyulling/5wintaek/refactor-all
5wintaek 251aef8
Chore: Ts 환경설정
5wintaek faa2389
Chore: tsconfig 수정
5wintaek f9d4ffa
refactor:SVG 타입 선언
5wintaek 8b49fee
Chore: Type오류 뜨지 않는거 문제 해결 (vite/client 추가)
5wintaek 2f60814
fix: Router 타입지정
5wintaek be8f8a1
fix: main 타입 지정
5wintaek b8e81c8
fix: style및 svg아이콘 타입지정
5wintaek 17fc9b8
fix:header Type지정
5wintaek ba0a495
Fix:Hint 타입 지정
5wintaek c0974b2
Fix: Modal 타입 지정
5wintaek e64c793
Fix:OnButton 타입 지정
5wintaek 304afb5
Fix:Question 타입 지정
5wintaek 779e13c
Fix: Content 타입 지정
5wintaek a73acfe
Fix: FooterTitle jsx->tsx 이름 변경
5wintaek 3481646
Fix: jsx->tsx 이름 변경
5wintaek d39d6ff
Fix: jsx->tsx 이름 변경
5wintaek f75aa91
Fix: ProfileCard Type 이유로 parseInt -> Math.ceil 바꿈
5wintaek 52c8c21
Fix: SelectAnswer 타입 지정
5wintaek f6a8b61
Fix: Article Type 지정
5wintaek 1b97c57
Fix: RetryButton type 지정
5wintaek 10b65cc
Fix: jsx->tsx 이름 변경
5wintaek d7a3d24
Fix: SelectTag type 지정
5wintaek 5f7f48e
Fix: jsx->tsx 이름 변경
5wintaek 0d2981f
Fix: jsx->tsx 이름 변경
5wintaek 40c9b4c
Fix: jsx->tsx 이름 변경
5wintaek 3088414
Fix: jsx->tsx 이름 변경 및 MyPage Type 지정
5wintaek 8ac60a0
Fix: isQuiz props 전달
5wintaek c4db632
Fix: Type지정
5wintaek dd38bb2
Merge branch '5wintaek/my-refactor' of https://github.com/Gyulling/gy…
5wintaek b061278
Fix: isQuiz props 전달
5wintaek 224882e
Merge branch '5wintaek/my-refactor' of https://github.com/Gyulling/gy…
5wintaek 235b278
Fix: Branch 꼬인거 다시 TS수정 후 업로드
5wintaek 3b566b3
Chore: 필요없는 주석 및 navigate 두번째 인자 삭제
5wintaek 061c09e
Chore: Router.jsx 필요없는 주석 삭제
5wintaek File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
이건 무슨 의미인가요 !!?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
이 설정은 ESLint가 import 문을 분석할 때 사용하는겁니당. .extension는 파일 확장자를 의미하는거고, 파일을 읽어들일떄
.jsx.js.ts.tsx확장자를 가진 파일들을 해석하는는 뜻There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
vite에서 TS를 사용할 떄 기본적으로 extensions 쪽에
.ts,.tsx에 확장자를 추가하는것을 권장합니다.eslint에서의 설정은 제가 타입오류지정을 해결하면서 eslint-plugin을 같이 깔면서 설정해둔것 같습니다. 굳이 없어도 되는 확장자 입니다