Conversation
GuzideGuzelbey
changed the title
GuzideGuzelbey
temporarily deployed
to
github-pages
jmf-umbraco
left a comment
jmf-umbraco
left a comment
There was a problem hiding this comment.
Looks great! I've added a couple of small suggestions. The biggest one is perhaps providing the user a little more feedback when the game is over - Did they win or lose? (It should be obvious, but sometimes users... can be users 😆)
Nice one!
|
|
||
| gameOver = true; | ||
|
|
||
| alert("Time is up! Game over!\nPress 'Restart' button to play again."); |
There was a problem hiding this comment.
Did the user win or lose? Maybe we could show that in the message?
There was a problem hiding this comment.
You are right, thanks for the feedback. Yes users!
BTW I also got some other feedbacks today for the user interaction in the presentation. So more explicit feedbacks and interactions are coming soon for the user:)
| body { | ||
| background-color: violet; | ||
| height: 100vh; | ||
| * { |
There was a problem hiding this comment.
Nice one. The box-sizing reset is extremely useful. I typically recommend that every web project should begin with it in their styles.
It would have been great if it was the standard, but unfortunately that's hard to change when you have hundreds of millions of websites relying on a particular behaviour!
| function getData(callback) { | ||
| fetch( | ||
| async function getData(callback) { | ||
| const response = await fetch( |
index.html
Outdated
| <div class="flip-counter">Flips: 0</div> | ||
| <div class="left"> | ||
| <div class="flip-counter">Flips: 0</div> | ||
| <div class="timer"><span>00</span>min<span>00</span>sec</div> |
There was a problem hiding this comment.
Are these <span> elements necessary? Perhaps we were going to target them from the javascript, but changed plans?
There was a problem hiding this comment.
Tbh I did not question it when I found it on a website. I did not know they were unnecessary :D
Done.
✅ Deploy Preview for mem-memorygame ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
2 participants
Project completed. Thanks in advance :)