Fix: Ensure DayOfWeek is preserved when converting GXDateTime to GXDate #45
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This Pull Request fixes an issue where the
DayOfWeekvalue was lost during the conversion fromGXDateTimetoGXDate.In the previous implementation, the
GXDate(GXDateTime)constructor did not copy theDayOfWeekfield, andGXCommon.setDatewas recalculating it from the calendar even if a specific value was already provided in theGXDateTimeobject.Changes
this.setDayOfWeek(forvalue.getDayOfWeek());to the constructor that accepts aGXDateTimeobject.setDatelogic to prioritize theDayOfWeekvalue stored in theGXDateTimeobject. If it's not set (0), it falls back to the calendar calculation, ensuring consistency with howsetDateTimebehaves.Why is this important?
In DLMS/COSEM, the
Day of Weekbyte is mandatory for the 5-byte date structure. Without this fix, manual overrides or specific day assignments inGXDateTimewere ignored when the object was treated as aGXDateduring serialization, leading to potential mismatches with the meter's expected values.