Skip to content

Ender5 max support #28

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
supfeer wants to merge 6 commits into
base: main
Choose a base branch
from
Open

Ender5 max support #28

supfeer wants to merge 6 commits into from

Conversation

@supfeer
Copy link

@supfeer supfeer commented May 29, 2025 •
edited
Loading

Current state - ready

git clone --branch ender5_max_support --single-branch https://github.com/supfeer/Creality-Helper-Script.git /usr/data/helper-script-e5m

sh /usr/data/helper-script-e5m/helper.sh

Общие инструкции:

Убедитесь, что ваш принтер определяется как "E5M" (модель "F004") для всех тестов.

1. Тестирование специфичных функций E5M (основано на коммите d908a16):

Поддержка Зуммера (Buzzer Support)

  • Расположение в меню E5M: Опция 6 (Install/Remove Menu).
  • Установка:
    • Проверьте, что $HS_CONFIG_FOLDER/buzzer-support.cfg создан как символическая ссылка на files/buzzer-support/buzzer-support-e5m.cfg.
    • Проверьте, что printer.cfg содержит [include Helper-Script/buzzer-support.cfg].
    • Протестируйте G-code команду BEEP.
  • Удаление:
    • Проверьте, что символическая ссылка и включение в printer.cfg удалены.

Макросы Управления Вентиляторами (Fans Control Macros)

  • Расположение в меню E5M: Опция 7 (Install/Remove Menu).
  • Перед установкой: Убедитесь, что gcode_macro.cfg либо не содержит секций [gcode_macro M106] / [gcode_macro M107], либо содержит стандартные.
  • Установка (E5M):
    • Проверьте создание резервной копии gcode_macro.cfg в $HS_BACKUP_FOLDER (например, gcode_macro.cfg.e5m_fans_backup_YYYYMMDDHHMMSS).
    • Проверьте, что стандартные секции [gcode_macro M106] и [gcode_macro M107] удалены из основного gcode_macro.cfg.
    • Проверьте, что содержимое files/macros/fans-control-e5m-definitions.cfg добавлено в gcode_macro.cfg.
    • Проверьте наличие файла-флага $HS_CONFIG_FOLDER/e5m_custom_fan_definitions_applied.flag.
    • Убедитесь, что printer.cfg не включает Helper-Script/fans-control.cfg.
    • Протестируйте G-code команды M106 и M107.
  • Удаление (E5M):
    • Проверьте восстановление gcode_macro.cfg из резервной копии (если существует).
    • Проверьте удаление файла резервной копии.
    • Проверьте удаление файла-флага.
    • (Опционально) Если бэкап отсутствовал, проверьте удаление макросов sed-командами.
  • Установка/Удаление (модель не E5M, например, K1):
    • Переключитесь на контекст другой модели.
    • Установите и затем удалите "Fans Control Macros", проверяя стандартную логику (линковка fans-control.cfg, включение в printer.cfg, комментирование/раскомментирование конфликтующих секций).

Регулировка Наклона Стола Винтами (Screws Tilt Adjust)

  • Расположение в меню E5M: Опция 11 (Install/Remove Menu).
  • Установка:
    • Проверьте, что $HS_CONFIG_FOLDER/screws-tilt-adjust.cfg является символической ссылкой на files/screws-tilt-adjust/screws-tilt-adjust-e5m.cfg.
    • Проверьте содержимое связанного файла screws-tilt-adjust-e5m.cfg на корректный порядок винтов: задний правый, задний левый, передний левый, передний правый.

2. Тестирование структуры меню E5M (после коммитов 0d1a0dd и 6d872bb, а также удалений пунктов меню):

Меню Установки E5M (scripts/menu/E5M/install_menu_E5M.sh):

  • Перейдите в "Install Menu" для E5M.
  • Убедитесь, что следующие пункты ОТСУТСТВУЮТ:
    • Klipper Adaptive Meshing & Purging
    • Nozzle Cleaning Fan Control
    • M600 Support
    • Git Backup
    • Camera Settings Control
  • Проверьте нумерацию и наличие следующих пунктов (общее количество 20):
    • ESSENTIALS: (1-3)
      • 1: Moonraker and Nginx
      • 2: Fluidd
      • 3: Mainsail
    • UTILITIES: (4-5)
      • 4: Entware
      • 5: Klipper Gcode Shell Command
    • IMPROVEMENTS: (6-11)
      • 6: Buzzer Support
      • 7: Fans Control Macros
      • 8: Improved Shapers Calibrations
      • 9: Useful Macros
      • 10: Save Z-Offset Macros
      • 11: Screws Tilt Adjust Support
    • CAMERA: (12-14)
      • 12: Moonraker Timelapse
      • 13: Nebula Camera Support (проверьте, что вызывает install_camera_settings_control или выдает ошибку при отсутствии зависимостей/наличии файла)
      • 14: USB Camera Support
    • REMOTE ACCESS: (15-20)
      • 15: OctoEverywhere
      • 16: Moonraker Obico
      • 17: GuppyFLO
      • 18: Mobileraker Companion
      • 19: OctoApp Companion
      • 20: SimplyPrint

Меню Удаления E5M (scripts/menu/E5M/remove_menu_E5M.sh):

  • Перейдите в "Remove Menu" для E5M.
  • Убедитесь, что ОТСУТСТВУЮТ те же пункты, что и в меню установки.
  • Проверьте нумерацию и наличие пунктов аналогично меню установки (общее количество 20).
  • Опция 13 "Nebula Camera Support" должна вызывать remove_camera_settings_control или выдавать ошибку, если не установлена.
  • Проверьте зависимости при удалении:
    • При попытке удаления "Entware" (опция 4), убедитесь, что скрипт не проверяет наличие "Git Backup" как зависимость.
    • При попытке удаления "Klipper Gcode Shell Command" (опция 5), убедитесь, что скрипт не проверяет наличие "Git Backup" как зависимость, но проверяет зависимости от других установленных функций, которые его требуют (Buzzer, Nebula/Camera Settings, Improved Shapers, Useful Macros).

3. Тестирование функциональности "Save Z-Offset Macros" (запрос был, изменений в коде не было):

  • Расположение в меню E5M: Опция 10 (Install/Remove Menu).
  • Установка: Установите "Save Z-Offset Macros".
  • Действие: Сохраните Z-смещение через стандартные команды Klipper.
  • Проверка: Перезагрузите Klipper (или принтер). Убедитесь, что после перезагрузки сохраненное Z-смещение было автоматически применено.

Testing Instructions for E5M

General Instructions:

Ensure your printer is identified as "E5M" (model "F004") for all tests.

1. Testing E5M Specific Functions (based on commit d908a16):

Buzzer Support

  • Location in E5M Menu: Option 6 (Install/Remove Menu).
  • Installation:
    • Verify that $HS_CONFIG_FOLDER/buzzer-support.cfg is created as a symbolic link to files/buzzer-support/buzzer-support-e5m.cfg.
    • Verify that printer.cfg includes [include Helper-Script/buzzer-support.cfg].
    • Test the BEEP G-code command.
  • Removal:
    • Verify that the symbolic link and the include in printer.cfg are removed.

Fans Control Macros

  • Location in E5M Menu: Option 7 (Install/Remove Menu).
  • Before Installation: Ensure gcode_macro.cfg either has no [gcode_macro M106] / [gcode_macro M107] sections or has standard ones.
  • Installation (E5M):
    • Verify that a backup of gcode_macro.cfg is created in $HS_BACKUP_FOLDER (e.g., gcode_macro.cfg.e5m_fans_backup_YYYYMMDDHHMMSS).
    • Verify that standard [gcode_macro M106] and [gcode_macro M107] sections are removed from the main gcode_macro.cfg.
    • Verify that the contents of files/macros/fans-control-e5m-definitions.cfg are appended to gcode_macro.cfg.
    • Verify the flag file $HS_CONFIG_FOLDER/e5m_custom_fan_definitions_applied.flag is created.
    • Ensure that printer.cfg does not include Helper-Script/fans-control.cfg.
    • Test M106 and M107 G-code commands.
  • Removal (E5M):
    • Verify restoration of gcode_macro.cfg from backup (if one exists).
    • Verify deletion of the backup file.
    • Verify deletion of the flag file.
    • (Optional) If no backup existed, verify macro removal by sed commands.
  • Installation/Removal (Non-E5M model, e.g., K1):
    • Switch to a different model context.
    • Install and then remove "Fans Control Macros," verifying standard logic (linking fans-control.cfg, inclusion in printer.cfg, commenting/uncommenting conflicting sections).

Screws Tilt Adjust

  • Location in E5M Menu: Option 11 (Install/Remove Menu).
  • Installation:
    • Verify that $HS_CONFIG_FOLDER/screws-tilt-adjust.cfg is a symbolic link to files/screws-tilt-adjust/screws-tilt-adjust-e5m.cfg.
    • Check the contents of the linked screws-tilt-adjust-e5m.cfg for the correct screw order: rear right, rear left, front left, front right.

2. Testing E5M Menu Structure (after commits 0d1a0dd and 6d872bb, and menu item removals):

E5M Install Menu (scripts/menu/E5M/install_menu_E5M.sh):

  • Navigate to the "Install Menu" for E5M.
  • Ensure the following items are ABSENT:
    • Klipper Adaptive Meshing & Purging
    • Nozzle Cleaning Fan Control
    • M600 Support
    • Git Backup
    • Camera Settings Control
  • Verify numbering and presence of the following items (total 20):
    • ESSENTIALS: (1-3)
      • 1: Moonraker and Nginx
      • 2: Fluidd
      • 3: Mainsail
    • UTILITIES: (4-5)
      • 4: Entware
      • 5: Klipper Gcode Shell Command
    • IMPROVEMENTS: (6-11)
      • 6: Buzzer Support
      • 7: Fans Control Macros
      • 8: Improved Shapers Calibrations
      • 9: Useful Macros
      • 10: Save Z-Offset Macros
      • 11: Screws Tilt Adjust Support
    • CAMERA: (12-14)
      • 12: Moonraker Timelapse
      • 13: Nebula Camera Support (verify it calls install_camera_settings_control or errors if dependencies are missing/file exists)
      • 14: USB Camera Support
    • REMOTE ACCESS: (15-20)
      • 15: OctoEverywhere
      • 16: Moonraker Obico
      • 17: GuppyFLO
      • 18: Mobileraker Companion
      • 19: OctoApp Companion
      • 20: SimplyPrint

E5M Remove Menu (scripts/menu/E5M/remove_menu_E5M.sh):

  • Navigate to the "Remove Menu" for E5M.
  • Ensure the SAME items listed for the install menu are ABSENT.
  • Verify numbering and presence of items similar to the install menu (total 20).
  • Option 13 "Nebula Camera Support" should call remove_camera_settings_control or error if not installed.
  • Verify dependencies on removal:
    • When attempting to remove "Entware" (option 4), ensure the script does not check for "Git Backup" as a dependency.
    • When attempting to remove "Klipper Gcode Shell Command" (option 5), ensure the script does not check for "Git Backup" but does check for dependencies on other installed features that require it (Buzzer, Nebula/Camera Settings, Improved Shapers, Useful Macros).

3. Testing "Save Z-Offset Macros" Functionality (request existed, no code changes):

  • Location in E5M Menu: Option 10 (Install/Remove Menu).
  • Installation: Install "Save Z-Offset Macros".
  • Action: Save Z-offset using standard Klipper commands.
  • Verification: Restart Klipper (or the printer). Ensure that the saved Z-offset has been automatically applied after the restart.

@aliashov-fnddev
feat(E5M): Implement model-specific buzzer support for E5M
8c6700c 
- Added a dedicated buzzer configuration file (`buzzer-support-e5m.cfg`)
  for the E5M model, containing specific G-code commands for beep functionality.
- Updated `scripts/paths.sh` to include a path variable for the new
  E5M-specific buzzer configuration.
- Modified `scripts/buzzer_support.sh` so that the `install_buzzer_support`
  function now links the E5M-specific configuration when the selected
  model is E5M, and the default configuration for all other models.
- Verified that the `remove_buzzer_support` function correctly handles
  removal for both default and E5M-specific configurations.
@aliashov-fnddev
feat: Add E5M printer support and customize features
d908a16 
Adds initial support for the Ender-5 S1 (E5M) printer model (F004).\n\nKey changes include:\n- New E5M specific menu files and main menu integration.\n- Updated paths.sh for E5M specific configurations.\n- Customized screws_tilt_adjust.cfg for E5M screw order.\n- Removed "Custom Boot Display" option from customize_menu_E5M.sh.\n- E5M Buzzer Support: Links E5M-specific buzzer config containing macros.\n- E5M Fans Control Macros (Option 9): Directly modifies gcode_macro.cfg with E5M specific M106/M107 definitions, including backup/restore. Non-E5M printers retain original fan control logic.\n- Updated E5M install/remove menus to check for a flag file for custom fan macros status.\n- Fixed helper.sh to source scripts from the E5M menu directory.
@aliashov-fnddev
refactor: Remove specific items from E5M install/remove menus
c1a5ad0 
Removes the following items from the E5M-specific installation and removal menus:
- Klipper Adaptive Meshing & Purging
- Nozzle Cleaning Fan Control
- M600 Support
- Git Backup
@aliashov-fnddev
feat: Add Nebula Camera Support option to E5M menus
0d1a0dd 
Adds a placeholder "Nebula Camera Support" option to the E5M install and remove menus under the "CAMERA" section.\n\n- This new option is added as item 14 in both menus.\n- Subsequent menu items have been renumbered.\n- The install case calls `install_camera_settings_control` as a placeholder.\n- The remove case calls `remove_camera_settings_control` as a placeholder.\n- A placeholder variable `NEBULA_CAMERA_FILE` is used in the checks; this may need adjustment once the actual implementation details for Nebula camera are known.\n\nThis change prepares the E5M menus for specific Nebula camera integration. Further changes will be needed to implement the actual logic if it differs from standard camera settings control.
@aliashov-fnddev
refactor: Remove "Camera Settings Control" from E5M menus
6d872bb 
Removes the "Camera Settings Control" option from the E5M install and remove menus.\n\n- The "Nebula Camera Support" option (which previously called the same underlying camera settings functions) is now option 13.\n- "USB Camera Support" is now option 14.\n- Subsequent menu items have been renumbered accordingly.\n- Total menu items reduced from 21 to 20.\n\nThis change simplifies the camera options in the E5M menu. The "Nebula Camera Support" entry still uses placeholder calls to `install_camera_settings_control` and `remove_camera_settings_control`.
@supfeer supfeer marked this pull request as ready for review June 2, 2025 06:25
@supfeer supfeer changed the title WIP: Ender5 max support Ender5 max support Sep 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@supfeer @aliashov-fnddev