Skip to content

fix Eclipse joker to not crash with other mods (talisman)#43

Open
Saydyrya90 wants to merge 3 commits intoGuilloryCraft:mainfrom
Saydyrya90:main
Open

fix Eclipse joker to not crash with other mods (talisman)#43
Saydyrya90 wants to merge 3 commits intoGuilloryCraft:mainfrom
Saydyrya90:main

Conversation

@Saydyrya90
Copy link
Copy Markdown

No description provided.

@stupxd
Copy link
Copy Markdown
Contributor

stupxd commented Mar 28, 2025

Uh, I think something like #48(my PR) works better for ease_dollars. Not entirely sure what was the idea for your change, though

@stupxd
Copy link
Copy Markdown
Contributor

stupxd commented Mar 28, 2025

Also, it isn't needed anymore because of my PR, but you forgot to define to_big(), so this fix would crash without Talisman

@Saydyrya90
Copy link
Copy Markdown
Author

You're not being fair this was 5 days ago 😭. And it did fix the joker before you implemented your fix today. Yeah I guess it would crash without talisman, I just assumed everyone uses talisman combined with their mods. I'm glad you fixed it, now I don't have to manually add the patch everytime an update is made 👍

@Saydyrya90
Copy link
Copy Markdown
Author

Fixed

@Saydyrya90 Saydyrya90 closed this Mar 28, 2025
@stupxd
Copy link
Copy Markdown
Contributor

stupxd commented Mar 29, 2025

You're not being fair this was 5 days ago 😭.

Noooo, I meant that the idea of your "fix" wasn't entirely clear to me (while it doesn't cause crashes, it seemed unnecessarily complicated).

Either way, my PR was missing Talisman compatibility for Eclipse, you didn't have to close your PR completely. But I can just copy your change over, so it's fine

@Saydyrya90 Saydyrya90 reopened this Mar 30, 2025
@Saydyrya90
Copy link
Copy Markdown
Author

I'm new to the github system so it's a bit weird also I only received an email now with the notification from this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants