fix Eclipse joker to not crash with other mods (talisman)#43
fix Eclipse joker to not crash with other mods (talisman)#43Saydyrya90 wants to merge 3 commits intoGuilloryCraft:mainfrom
Conversation
|
Uh, I think something like #48(my PR) works better for ease_dollars. Not entirely sure what was the idea for your change, though |
|
Also, it isn't needed anymore because of my PR, but you forgot to define |
|
You're not being fair this was 5 days ago 😭. And it did fix the joker before you implemented your fix today. Yeah I guess it would crash without talisman, I just assumed everyone uses talisman combined with their mods. I'm glad you fixed it, now I don't have to manually add the patch everytime an update is made 👍 |
|
Fixed |
Noooo, I meant that the idea of your "fix" wasn't entirely clear to me (while it doesn't cause crashes, it seemed unnecessarily complicated). Either way, my PR was missing Talisman compatibility for Eclipse, you didn't have to close your PR completely. But I can just copy your change over, so it's fine |
|
I'm new to the github system so it's a bit weird also I only received an email now with the notification from this. |
No description provided.