Fix: Release ImageMagick resources in chafa.loader.Loader
#76
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
BTW, thank you for your work. I just realized that in an effort to keep the PR brief, it may have come across as a bit salty. That was not the intention. |
Owner
|
Amazing work and a good catch! I'll merge this now and release it alongside the updated bindings for chafa 1.16 when those are ready! Also, really awesome you wrote a test for this too! Above and beyond! Best, |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Recently I was experiencing problems loading many images with
chafa.pyso I went to investigate. It turns out thatchafa.loader.Loader()does not destroy theMagicWandobject after exporting the image's pixels.This PR is a minimal fix. The loader should probably check for error conditions and raise an appropriate exception in that case.