Add 'from common_func import ...' support#3
Draft
garyttierney wants to merge 2 commits intoGrimrukh:mainfrom
Draft
Add 'from common_func import ...' support#3garyttierney wants to merge 2 commits intoGrimrukh:mainfrom
garyttierney wants to merge 2 commits intoGrimrukh:mainfrom
Conversation
Owner
|
This is looking good. Yes, I think this could be easily expanded to import event functions from any file - we'd just need to tell the compiler that only the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is still a WIP so I've marked it as a draft. There's no error handling yet and the discovery of
common_funcis a little out of place, but it does the trick for me so far in DS3.Still todo:
from common_func import *import common_funcDo you think this is the right time/place to be reading
custom_func.pyand parsing it's AST (i.e. on demand as opposed to passing in aload_common_func=Trueto an EMEVD instance).