Skip to content

Conversation

@JohnWangDataAnalyst
Copy link
Collaborator

to speed up fitting and keep the same fitting results

@JohnGriffiths
Copy link
Collaborator

@JohnWangDataAnalyst please take a closer look at the effects of big code base changes like this

I ran with the updated code and the only example that depends on this function seems to have gone very skew

image

This is what it looks like without the delays change

image

Also, worth noting, I don't think the orig example shown there is quite looking as it should either.

Please look into these things and lmk where you get.

@JohnWangDataAnalyst
Copy link
Collaborator Author

LEd_p2e = LEd_p2e + ptmatmul(dg_f, E - I)
I think it is here... the same variable is used in the integration loop.
solution: LEd_p2e = Ed_p2e + ptmatmul(dg_f, E - I) and redefined the ED_p2e in the window loop
similar to other populations I and P
you want to change it directly or want to get a new PR?

@JohnGriffiths
Copy link
Collaborator

closing, will be resumed on a new PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants