Skip to content

Conversation

@sachet-mittal
Copy link

$ flake8 *.py
ExtractMainContent.py:34:80: E501 line too long (144 > 79 characters)
ExtractMainContent.py:48:80: E501 line too long (90 > 79 characters)
ExtractMainContent.py:50:80: E501 line too long (90 > 79 characters)
ExtractMainContent.py:52:80: E501 line too long (97 > 79 characters)
ExtractMainContent.py:55:80: E501 line too long (131 > 79 characters)
ExtractMainContent.py:57:80: E501 line too long (101 > 79 characters)
Extractor.py:87:80: E501 line too long (84 > 79 characters)
Main.py:40:80: E501 line too long (120 > 79 characters)
Main.py:59:80: E501 line too long (89 > 79 characters)
NewsPulling.py:15:80: E501 line too long (94 > 79 characters)
NewsPulling.py:31:80: E501 line too long (113 > 79 characters)

$ flake8 *.py
ExtractMainContent.py:34:80: E501 line too long (144 > 79 characters)
ExtractMainContent.py:48:80: E501 line too long (90 > 79 characters)
ExtractMainContent.py:50:80: E501 line too long (90 > 79 characters)
ExtractMainContent.py:52:80: E501 line too long (97 > 79 characters)
ExtractMainContent.py:55:80: E501 line too long (131 > 79 characters)
ExtractMainContent.py:57:80: E501 line too long (101 > 79 characters)
Extractor.py:87:80: E501 line too long (84 > 79 characters)
Main.py:40:80: E501 line too long (120 > 79 characters)
Main.py:59:80: E501 line too long (89 > 79 characters)
NewsPulling.py:15:80: E501 line too long (94 > 79 characters)
NewsPulling.py:31:80: E501 line too long (113 > 79 characters)
ConfigurationReader.__Limit=cfg['Limit']
#print ConfigurationReader.__Limit
ConfigurationReader.__WebsiteSupported=cfg['WebsiteSupported']
#print ConfigurationReader.__WebsiteSupported
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i dont know about the the pep8 . Can u let me know why the comment has been removed?

if newsSourceNumber == EXIT:
sys.exit()
if (newsSourceNumber >=len(newsSources)):
print ("Please select the index no less than "+ str(len(newsSources)))
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

removing parenthesis from the print doesn't make it compliant only for the python 2.7 while having it makes it work for both python 2.7 and python 3.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If the aim is to make it compatible between python2 and python3, generally either

  1. 'from future import print_function' is used
    Or
  2. six is made a part of the library. Refer http://six.readthedocs.io/ .

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it is is better to go with 'from future import print_function' at this point in time.

@sachet-mittal
Copy link
Author

sachet-mittal commented Oct 9, 2017 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants