fix[next][dace]: Better usage of SubgraphContext during SDFG lowering
#2413
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
edopao
changed the title
SubgraphContext during SDFG loweringSubgraphContext during SDFG lowering
This reverts commit 2dbda35.
Contributor
philip-paul-mueller
left a comment
philip-paul-mueller
left a comment
There was a problem hiding this comment.
An initial review, if you need clarification let me know.
src/gt4py/next/program_processors/runners/dace/lowering/gtir_to_sdfg.py
Outdated
Show resolved
Hide resolved
src/gt4py/next/program_processors/runners/dace/lowering/gtir_to_sdfg.py
Outdated
Show resolved
Hide resolved
src/gt4py/next/program_processors/runners/dace/lowering/gtir_to_sdfg.py
Outdated
Show resolved
Hide resolved
src/gt4py/next/program_processors/runners/dace/lowering/gtir_to_sdfg.py
Outdated
Show resolved
Hide resolved
src/gt4py/next/program_processors/runners/dace/lowering/gtir_to_sdfg_primitives.py
Show resolved
Hide resolved
src/gt4py/next/program_processors/runners/dace/lowering/gtir_to_sdfg_scan.py
Show resolved
Hide resolved
edopao
commented
Dec 19, 2025
Contributor
Author
edopao
left a comment
edopao
left a comment
There was a problem hiding this comment.
Thanks for the review comments!
src/gt4py/next/program_processors/runners/dace/lowering/gtir_to_sdfg.py
Outdated
Show resolved
Hide resolved
src/gt4py/next/program_processors/runners/dace/lowering/gtir_to_sdfg_primitives.py
Show resolved
Hide resolved
src/gt4py/next/program_processors/runners/dace/lowering/gtir_to_sdfg_scan.py
Show resolved
Hide resolved
src/gt4py/next/program_processors/runners/dace/lowering/gtir_to_sdfg.py
Outdated
Show resolved
Hide resolved
Contributor
philip-paul-mueller
left a comment
philip-paul-mueller
left a comment
There was a problem hiding this comment.
It looks okay, there are some parts I have a bit trouble understanding, especially the motivation behind it, but there should be nothing blocking.
src/gt4py/next/program_processors/runners/dace/lowering/gtir_to_sdfg.py
Outdated
Show resolved
Hide resolved
Contributor
Author
|
Performance looks good: We wait for the icon4py PR#898 to be merged, because we need to remove a write-write pattern which dace state fusion cannot handle (see spcl/dace#2256). This PR reveals the issue, because of non-deterministic code generation, by introducing a new name convention of transient arrays and map nodes. |
Contributor
Author
|
@philip-paul-mueller I think I have addressed all your review comments. |
philip-paul-mueller
approved these changes
Jan 8, 2026
Contributor
philip-paul-mueller
left a comment
philip-paul-mueller
left a comment
There was a problem hiding this comment.
I have some smallish suggestions, nothing big that would justify another round.
src/gt4py/next/program_processors/runners/dace/lowering/gtir_to_sdfg.py
Outdated
Show resolved
Hide resolved
src/gt4py/next/program_processors/runners/dace/lowering/gtir_to_sdfg.py
Outdated
Show resolved
Hide resolved
src/gt4py/next/program_processors/runners/dace/lowering/gtir_to_sdfg.py
Outdated
Show resolved
Hide resolved
src/gt4py/next/program_processors/runners/dace/lowering/gtir_to_sdfg.py
Outdated
Show resolved
Hide resolved
src/gt4py/next/program_processors/runners/dace/lowering/gtir_to_sdfg.py
Outdated
Show resolved
Hide resolved
src/gt4py/next/program_processors/runners/dace/lowering/gtir_to_sdfg_primitives.py
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change the visitor class so that we can generate unique labels for temporaries/maps/tasklets across all nested SDFG.