Added Event IDs and removeEvent() function#30
Added Event IDs and removeEvent() function#30RealWhimsy wants to merge 2 commits intoGrible:masterfrom
Conversation
The removeEvent() function allows removal of events by their ID
|
Thanks for the PR, seems like a useful addition 👍. Your changes were however committed on the dist files instead of the source files, so you bypassed the build system (and it's tests and code style rules). Also, I was wondering how events get their ID in this approach? |
Added a line that assigns an ID to a timetable - entry item on its creation in addEvent()
|
I forgot to add a line of code that actually assigned the IDs, the correct version is now committed. Also I'm sorry for commiting on the wrong files, this is my first contribution to another repository on GitHub. If you could give me a pointer on what files to modify it would be greatly appreciated, since I can only find a dist folder but no src/source folder in my forked repository. |
|
There's an |
The removeEvent() function allows removal of events by their ID.
I used this in a project to allow the user to detect click events on entries in the timetable and remove them. The ID is needed to distinguish between entries with similar names.