refactor(mito2): remove PrimaryKey variants#7982
Open
evenyag wants to merge 6 commits intoGreptimeTeam:mainfrom
Open
refactor(mito2): remove PrimaryKey variants#7982evenyag wants to merge 6 commits intoGreptimeTeam:mainfrom
evenyag wants to merge 6 commits intoGreptimeTeam:mainfrom
Conversation
Signed-off-by: evenyag <realevenyag@gmail.com>
Signed-off-by: evenyag <realevenyag@gmail.com>
Signed-off-by: evenyag <realevenyag@gmail.com>
Signed-off-by: evenyag <realevenyag@gmail.com>
Signed-off-by: evenyag <realevenyag@gmail.com>
Signed-off-by: evenyag <realevenyag@gmail.com>
Contributor
There was a problem hiding this comment.
Code Review
This pull request refactors the mito2 engine to remove legacy primary key format reading paths and projection mappers, consolidating the codebase around the flat format. Key changes include the removal of the ReadFormat enum in favor of FlatReadFormat, the replacement of ProjectionMapper with FlatProjectionMapper, and the deletion of associated compatibility layers such as CompatReader and PrimaryKeyCompatBatch. Additionally, PruneReader and RowGroupReader have been removed or simplified, and several utility functions have been transitioned to top-level functions. I have no feedback to provide.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I hereby agree to the terms of the GreptimeDB CLA.
Refer to a related PR or issue link (optional)
#7732
What's changed and what's your intention?
Remove the old
PrimaryKeyread format variants and make the scan/read path use the flat format exclusively. This is a cleanup PR that drops ~1800 lines of dead code after the flat format became the only active path.Summary of changes:
PrimaryKeyvariants fromReadFormat,BatchReader, and related enumsFlatProjectionMapperdirectly instead of theProjectionMapperwrapper that dispatched between flat and primary-key modesprojection.rsandprune.rsBatchvsFlatBatchdistinction)ReadFormat::Flatdirectly in the SST parquet reader and file range code, simplifyingParquetReaderBuilder,FileRangeContextBuilder, and format helpersPR Checklist
Please convert it to a draft if some of the following conditions are not met.