Merged
Conversation
…other active events
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR enhances the reset() functionality in the timing utility to support resetting all events when called at the root level. Previously, reset() would silently return when called at root level; now it resets all root events and their children.
- Added recursive
reset_event_and_children()helper method to properly reset events and all descendants - Modified
reset()to reset all root events when called at root level (when_current_eventis nullptr) - Extended test coverage to verify root-level reset behavior
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| src/green/utils/timing.h | Added reset_event_and_children() helper method and updated reset() to handle root-level resets; updated documentation to reflect new behavior |
| test/utils_test.cpp | Added clarifying comments and test assertions to verify root-level reset functionality |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Modify reset function in timing for flexible operation inside and outside other active events.