Fix accumulation of time duration in subsequent events#3
Merged
egull merged 8 commits intoGreen-Phys:mainfrom Nov 6, 2025
Merged
Fix accumulation of time duration in subsequent events#3egull merged 8 commits intoGreen-Phys:mainfrom
egull merged 8 commits intoGreen-Phys:mainfrom
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR adds two new features to the timing utility: (1) an accumulate mode that controls whether event durations are accumulated across multiple start/end cycles or replaced, and (2) a reset() method to clear child event durations.
Key changes:
- Added
accumulateparameter tostart()method with default valuefalse - Added
reset()method to zero out child event durations - Added comprehensive tests for both features
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| src/green/utils/timing.h | Added accumulate field to event_t struct, modified start() to accept accumulate parameter, updated end() to conditionally accumulate or replace duration, added reset() method with documentation |
| test/utils_test.cpp | Added "Test Accumulate" section testing both accumulate=true and accumulate=false modes, added "Test Reset" section verifying child events are zeroed |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Contributor
There was a problem hiding this comment.
Pull Request Overview
Copilot reviewed 2 out of 2 changed files in this pull request and generated 4 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
egull
approved these changes
Nov 6, 2025
Contributor
|
Looks good to me. Let's merge. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In the current default behavior of timing module, repeated calls of
startandstopfor same event accumulates the duration of the event. While, in general, this is good within a SCF iteration, transfer of the accumulateddurationacross multiple iterations is problematic.This PR fixes this issue by adding a boolean keyword
accumulatein the declaration ofevent.Tests are also added for the new functionality.