Skip to content

minor typo in compare_version_strings#9

Merged
gauravharsha merged 1 commit intomainfrom
grids-update
Feb 23, 2026
Merged

minor typo in compare_version_strings#9
gauravharsha merged 1 commit intomainfrom
grids-update

Conversation

@gauravharsha
Copy link
Contributor

No description provided.

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Fixes an error message in compare_version_strings so that parsing failures for the second version string correctly reference v2 (instead of mistakenly printing v1). This improves diagnosability of version-mismatch errors used by SC loop version-consistency checks.

Changes:

  • Corrected the thrown std::runtime_error message when v2 fails to parse in compare_version_strings.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@gauravharsha gauravharsha merged commit 1082f3d into main Feb 23, 2026
5 checks passed
@codecov-commenter
Copy link

Codecov Report

❌ Patch coverage is 0% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 95.65%. Comparing base (dcbd62f) to head (6e77665).
⚠️ Report is 4 commits behind head on main.

Files with missing lines Patch % Lines
src/green/sc/common_defs.h 0.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main       #9   +/-   ##
=======================================
  Coverage   95.65%   95.65%           
=======================================
  Files          10       10           
  Lines         690      690           
=======================================
  Hits          660      660           
  Misses         30       30           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants