Compatibility for new and old grid files#7
Conversation
|
NOTE: tests will fail until the pull request for |
There was a problem hiding this comment.
Pull request overview
Adds grid-file version tracking and restart-time compatibility checks to prevent mixing old/new green-grids formats, with accompanying test updates.
Changes:
- Persist
__grids_version__into SC results files and validate version compatibility on restart. - Introduce a dedicated
outdated_results_file_errorexception type. - Extend SC tests/CMake to supply grid parameters and add restart/version mismatch scenarios.
Reviewed changes
Copilot reviewed 4 out of 5 changed files in this pull request and generated 5 comments.
| File | Description |
|---|---|
src/green/sc/sc_loop.h |
Writes __grids_version__ to results and checks grids/results version compatibility during restart. |
src/green/sc/except.h |
Adds outdated_results_file_error exception. |
test/sc_test.cpp |
Updates tests to initialize grids/transformer usage and adds restart/version compatibility cases. |
test/CMakeLists.txt |
Adds TEST_PATH compile definition to locate test data files. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
egull
left a comment
There was a problem hiding this comment.
Thanks! Have a look at the github comments but merge once you feel it's ready. Overall looks good!
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #7 +/- ##
==========================================
- Coverage 96.45% 95.65% -0.80%
==========================================
Files 10 10
Lines 648 690 +42
==========================================
+ Hits 625 660 +35
- Misses 23 30 +7 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 5 out of 7 changed files in this pull request and generated 14 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
lingo in comments Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
|
Copilot reviews addressed. Merging PR |
Add version checks for new grid files (pending the completion of
green-gridsPR 8):__grids_version__to the output file