Skip to content

fix compatibility with pyscf 2.0.1 by explicitly writing the unique_with_wrap_around function#2

Merged
egull merged 47 commits intoGreen-Phys:mainfrom
gauravharsha:main
Sep 15, 2025
Merged

fix compatibility with pyscf 2.0.1 by explicitly writing the unique_with_wrap_around function#2
egull merged 47 commits intoGreen-Phys:mainfrom
gauravharsha:main

Conversation

@gauravharsha
Copy link
Collaborator

@gauravharsha gauravharsha commented Aug 27, 2025

This should fix #1 by explicitly providing the unique_with_wrap_around function

@gauravharsha
Copy link
Collaborator Author

Lots of commits in the way (predicting Github actions / workflow can be tricky). But finally, there are several testing wheels implemented for deployment of green-igen.

Key thing to consider: Our reference favorite branch of pyscf 2.0.1 is no longer compatible with new versions of scipy. So, for testing, I am cherry picking a few older versions of libraries.

@egull Could you review and merge this pull request?

@egull egull requested a review from Copilot September 14, 2025 10:59
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR fixes compatibility with PySCF 2.0.1 by implementing a local version of the unique_with_wrap_around function that was removed from PySCF's public API. The changes ensure the package continues to work with newer PySCF versions while maintaining existing functionality.

Key changes:

  • Implements a local unique_with_wrap_around function to replace the one removed from PySCF
  • Updates build configuration to support quadmath library linking
  • Adds CI/CD workflow for automated testing across Python and PySCF versions

Reviewed Changes

Copilot reviewed 6 out of 6 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
python/green_igen/df.py Removes import of unique_with_wrap_around from PySCF and adds local implementation
python/green_igen/linalg_helper.py Updates scipy.linalg.solve parameter from sym_pos to assume_a
src/CMakeLists.txt Adds quadmath library linking and math library support
CMakeLists.txt Adds quadmath library detection
pyproject.toml Version bump and author addition
.github/workflows/python-package.yml Adds comprehensive CI workflow

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

Copy link
Contributor

@egull egull left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Except for the copilot comment this looks good. Could you please check the argument of assume_a and, once you know, either push a fix and merge or directly merge?

Copy link
Contributor

@egull egull left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you moved Sergei's email to your name. Propose to update to your own email :-)

@gauravharsha
Copy link
Collaborator Author

My bad, missed it in a hurry. Should be fixed now.

@egull egull merged commit dcea08a into Green-Phys:main Sep 15, 2025
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

The reference version of PySCF 2.0.1 is not supported by green-igen

3 participants