Skip to content

refactor grids version testing#6

Merged
gauravharsha merged 2 commits intomainfrom
grids-version
Feb 26, 2026
Merged

refactor grids version testing#6
gauravharsha merged 2 commits intomainfrom
grids-version

Conversation

@gauravharsha
Copy link
Contributor

No description provided.

@codecov-commenter
Copy link

codecov-commenter commented Feb 26, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 100.00%. Comparing base (0012150) to head (fbd71d8).
⚠️ Report is 5 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff             @@
##             main        #6      +/-   ##
===========================================
+ Coverage   99.16%   100.00%   +0.83%     
===========================================
  Files           5         4       -1     
  Lines         240       222      -18     
===========================================
- Hits          238       222      -16     
+ Misses          2         0       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Refactors the grids version consistency check used by the C++ application by removing the local version-string comparison helper and delegating version validation to a green::grids helper.

Changes:

  • Removed compare_version_strings from green/ac/common_defs.h and deleted its associated unit test.
  • Updated main.cpp to call green::grids::check_grids_version_in_hdf5(...) instead of doing an inline attribute read + comparison.

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 3 comments.

File Description
test/ac_test.cpp Removes the version string comparison test case that depended on the deleted helper.
src/green/ac/common_defs.h Removes the inline version string comparison helper from a public header.
main.cpp Replaces local HDF5 attribute/version check logic with a green::grids helper call.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@gauravharsha gauravharsha requested a review from egull February 26, 2026 15:13
Copy link
Contributor

@egull egull left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Totally fine like it is, or with copilot's changes.

@gauravharsha gauravharsha marked this pull request as ready for review February 26, 2026 20:10
@gauravharsha gauravharsha merged commit 7ea2b14 into main Feb 26, 2026
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants