Skip to content

add grids version checks#4

Merged
gauravharsha merged 13 commits intomainfrom
grids-version
Feb 24, 2026
Merged

add grids version checks#4
gauravharsha merged 13 commits intomainfrom
grids-version

Conversation

@gauravharsha
Copy link
Contributor

No description provided.

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adds a grids-version compatibility check when reading Nevanlinna input data, using a new shared helper to compare version strings.

Changes:

  • Added green::ac::compare_version_strings to parse/compare major.minor.patch[...suffix...] version strings.
  • Added HDF5 __grids_version__ attribute check in read_nevanlinna_data and error out when the data file and grids file versions differ.
  • Added/updated inline documentation around read_nevanlinna_data.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 4 comments.

File Description
src/green/ac/common_defs.h Introduces a version-string comparison utility used for grids/data compatibility checks.
main.cpp Enforces grids-version matching between the input data file and the grids transformer version during reads.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@codecov-commenter
Copy link

codecov-commenter commented Feb 23, 2026

Codecov Report

❌ Patch coverage is 88.88889% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 99.16%. Comparing base (2a9b12f) to head (142db64).
⚠️ Report is 14 commits behind head on main.

Files with missing lines Patch % Lines
src/green/ac/common_defs.h 88.88% 2 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##              main       #4      +/-   ##
===========================================
- Coverage   100.00%   99.16%   -0.84%     
===========================================
  Files            4        5       +1     
  Lines          222      240      +18     
===========================================
+ Hits           222      238      +16     
- Misses           0        2       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 5 out of 5 changed files in this pull request and generated 4 comments.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

proper spelling

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Copy link
Contributor

@egull egull left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Happy with the pull request, but have another look at the copilot comments and consider or discard them.

@gauravharsha gauravharsha merged commit 41cfc70 into main Feb 24, 2026
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants