Conversation
There was a problem hiding this comment.
Pull request overview
Adds a grids-version compatibility check when reading Nevanlinna input data, using a new shared helper to compare version strings.
Changes:
- Added
green::ac::compare_version_stringsto parse/comparemajor.minor.patch[...suffix...]version strings. - Added HDF5
__grids_version__attribute check inread_nevanlinna_dataand error out when the data file and grids file versions differ. - Added/updated inline documentation around
read_nevanlinna_data.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 4 comments.
| File | Description |
|---|---|
src/green/ac/common_defs.h |
Introduces a version-string comparison utility used for grids/data compatibility checks. |
main.cpp |
Enforces grids-version matching between the input data file and the grids transformer version during reads. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #4 +/- ##
===========================================
- Coverage 100.00% 99.16% -0.84%
===========================================
Files 4 5 +1
Lines 222 240 +18
===========================================
+ Hits 222 238 +16
- Misses 0 2 +2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 5 out of 5 changed files in this pull request and generated 4 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
proper spelling Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
egull
left a comment
There was a problem hiding this comment.
Happy with the pull request, but have another look at the copilot comments and consider or discard them.
No description provided.