[pull] main from tc39:main

.github/PULL_REQUEST_TEMPLATE.md

@@ -4,6 +4,7 @@ If you are changing the signature or behavior of an existing construct, please c
 * [Web IDL](https://webidl.spec.whatwg.org/) — [file an issue](https://github.com/whatwg/webidl/issues/new)
 * [HTML Standard](https://html.spec.whatwg.org/) — [file an issue](https://github.com/whatwg/html/issues/new)
 * [ECMAScript Intl API](https://tc39.es/ecma402/) - [file an issue](https://github.com/tc39/ecma402/issues/new)
+* [WebAssembly](https://webassembly.github.io/spec/) - [file an issue](https://github.com/WebAssembly/spec/issues/new)
 
 Note: please ensure that the "Allow edits and access to secrets by maintainers" checkbox remains checked.
 -->

.github/workflows/build.yml

@@ -5,12 +5,14 @@ on: [pull_request, push]
 jobs:
   build:
     name: 'build & lint ecmarkup'
-    runs-on: ubuntu-latest
+    runs-on: ubuntu-22.04
 
     steps:
-      - uses: actions/checkout@v3
-      - uses: ljharb/actions/node/install@d9f477827ed71a259056764107f74afc29febcae
-        name: 'nvm install lts/* && npm ci'
+      - uses: actions/checkout@v4
+      - uses: ljharb/actions/node/install@7f214d8efdbdcefc96ad9689663ef387a195deec
+        name: 'nvm install lts/* && npm ci --no-audit'
+        env:
+          NPM_CONFIG_AUDIT: false
         with:
           node-version: lts/*
           use-npm-ci: true

.github/workflows/deploy.yml

@@ -8,17 +8,19 @@ on:
 jobs:
   deploy:
     name: 'deploy github pages'
-    runs-on: ubuntu-latest
+    runs-on: ubuntu-22.04
     if: ${{ github.repository == 'tc39/ecma262' }}
 
     steps:
-      - uses: actions/checkout@v3
-      - uses: ljharb/actions/node/install@d9f477827ed71a259056764107f74afc29febcae
-        name: 'nvm install lts/* && npm ci'
+      - uses: actions/checkout@v4
+      - uses: ljharb/actions/node/install@7f214d8efdbdcefc96ad9689663ef387a195deec
+        name: 'nvm install lts/* && npm ci --no-audit'
+        env:
+          NPM_CONFIG_AUDIT: false
         with:
           node-version: lts/*
           use-npm-ci: true
       - run: npm run build-only
-      - run: ./scripts/auto-deploy.sh
+      - run: ./scripts/deploy-github-pages.sh
         env:
           GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}

.github/workflows/enforce-format.yml

@@ -5,12 +5,14 @@ on: [pull_request]
 jobs:
   build:
     name: 'enforce format'
-    runs-on: ubuntu-latest
+    runs-on: ubuntu-22.04
 
     steps:
-      - uses: actions/checkout@v3
-      - uses: ljharb/actions/node/install@d9f477827ed71a259056764107f74afc29febcae
-        name: 'nvm install lts/* && npm ci'
+      - uses: actions/checkout@v4
+      - uses: ljharb/actions/node/install@7f214d8efdbdcefc96ad9689663ef387a195deec
+        name: 'nvm install lts/* && npm ci --no-audit'
+        env:
+          NPM_CONFIG_AUDIT: false
         with:
           node-version: lts/*
           use-npm-ci: true

.github/workflows/esmeta-installer/action.yml

@@ -0,0 +1,37 @@
+name: 'install esmeta'
+
+runs:
+  using: "composite"
+  steps:
+    - name: setup JDK
+      uses: actions/setup-java@v4
+      with:
+        distribution: temurin
+        java-version: 17
+    - name: setup SBT
+      uses: sbt/setup-sbt@v1
+    - name: set esmeta version and path
+      shell: bash
+      run: |
+        # v0.7.3
+        echo "ESMETA_VERSION=9066adf1edefd5d7e8dbc6eaa878242bb591cc2b" >> $GITHUB_ENV
+        echo "ESMETA_HOME=vendor/esmeta" >> $GITHUB_ENV
+    - name: clone esmeta
+      shell: bash
+      run: |
+        mkdir -p "${ESMETA_HOME}"
+        cd ${ESMETA_HOME}
+        git init
+        git remote add origin https://github.com/es-meta/esmeta.git
+        git fetch --depth 1 origin "$ESMETA_VERSION"
+        git checkout FETCH_HEAD
+    - name: build esmeta
+      shell: bash
+      run: |
+        cd "${ESMETA_HOME}"
+        sbt assembly
+    - name: link ecma262
+      shell: bash
+      run: |
+        rmdir "${ESMETA_HOME}"/ecma262 \
+          && ln -s "$(pwd)" "${ESMETA_HOME}"/ecma262

.github/workflows/esmeta-typecheck.yml

@@ -5,35 +5,18 @@ on: [pull_request]
 jobs:
   esmeta-typecheck:
     name: 'esmeta typecheck'
-    runs-on: ubuntu-latest
-
-    env:
-      ESMETA_HOME: vendor/esmeta
-
+    runs-on: ubuntu-22.04
     steps:
-      - name: Checkout
-        uses: actions/checkout@v3
-      - name: Setup JDK
-        uses: actions/setup-java@v3
-        with:
-          distribution: temurin
-          java-version: 17
-      - name: download esmeta
-        run: |
-          mkdir -p "${ESMETA_HOME}"
-          cd "${ESMETA_HOME}"
-          git init
-          git remote add origin https://github.com/es-meta/esmeta.git
-          git fetch --depth 1 origin 088029201f0de736fdb8f30ca0a96bef26a52089 ;# v0.4.1
-          git checkout FETCH_HEAD
-      - name: build esmeta
-        run: |
-          cd "${ESMETA_HOME}"
-          sbt assembly
-      - name: link
-        run: |
-          rmdir "${ESMETA_HOME}"/ecma262 \
-            && ln -s "$(pwd)" "${ESMETA_HOME}"/ecma262
+      - name: checkout
+        uses: actions/checkout@v4
+      - name: install esmeta
+        uses: ./.github/workflows/esmeta-installer
       - name: typecheck
-        run: '"${ESMETA_HOME}"/bin/esmeta tycheck -status -tycheck:log -tycheck:ignore=esmeta-ignore.json'
-
+        run: '"${ESMETA_HOME}"/bin/esmeta tycheck -status -extract:log -tycheck:log -tycheck:ignore=esmeta-ignore.json'
+      - name: create logs archive
+        run: 'tar --verbose --verbose --create --gzip --file esmeta-logs.tar.gz --directory="${ESMETA_HOME}" logs/'
+      - name: upload logs archive
+        uses: actions/upload-artifact@v4
+        with:
+          name: esmeta-logs
+          path: esmeta-logs.tar.gz

.github/workflows/esmeta-yetcheck.yml

@@ -0,0 +1,25 @@
+name: 'esmeta yet phrases detection'
+
+on: [pull_request]
+
+jobs:
+  esmeta-yetcheck:
+    name: 'esmeta yet phrases detection'
+    runs-on: ubuntu-22.04
+    steps:
+      - name: checkout
+        uses: actions/checkout@v4
+        with:
+          fetch-depth: 0
+      - name: install esmeta
+        uses: ./.github/workflows/esmeta-installer
+      - name: check for newly-introduced phrases
+        env:
+          FILE_PATH: spec.html
+          BASE_SHA: ${{ github.event.pull_request.base.sha }}
+          HEAD_SHA: ${{ github.sha }}
+        run: |
+          "${ESMETA_HOME}"/bin/esmeta yet-check \
+            -status -yet-check:github-alert -yet-check:log \
+            "${BASE_SHA}" "${HEAD_SHA}"
+          cat "${ESMETA_HOME}"/logs/yet-check/summary.md >> $GITHUB_STEP_SUMMARY

.github/workflows/ipr.yml

@@ -11,16 +11,18 @@ on:
 jobs:
   build:
     name: 'check IPR form'
-    runs-on: ubuntu-latest
+    runs-on: ubuntu-22.04
 
     steps:
-      - uses: actions/checkout@v3
-      - uses: ljharb/actions/node/install@d9f477827ed71a259056764107f74afc29febcae
-        name: 'nvm install lts/* && npm ci'
+      - uses: actions/checkout@v4
+      - uses: ljharb/actions/node/install@7f214d8efdbdcefc96ad9689663ef387a195deec
+        name: 'nvm install lts/* && npm ci --no-audit'
+        env:
+          NPM_CONFIG_AUDIT: false
         with:
           node-version: lts/*
           use-npm-ci: true
-      - run: 'npm run ipr-check'
+      - run: npm run ipr-check ${{ github.event_name == 'pull_request' && github.event.pull_request.head.sha || 'HEAD' }}
         env:
           GH_TOKEN: ${{ secrets.GH_IPR_TOKEN }}
           GOOGLE_API_KEY: ${{ secrets.GOOGLE_API_KEY }}

.github/workflows/pr-preview.yml

@@ -0,0 +1,116 @@
+name: 'ecma262'
+
+on:
+  pull_request_target:
+    types: [opened, synchronize, reopened, labeled]
+
+jobs:
+  check-membership:
+    name: 'check membership'
+    runs-on: ubuntu-22.04
+    outputs:
+      result: ${{ steps.test-membership.outputs.result }}
+      should-run: ${{ steps.should-run.outputs.result }}
+    steps:
+      - uses: actions/github-script@v7
+        id: should-run
+        with:
+          result-encoding: string
+          script: |
+            const { action, label } = context.payload;
+
+            // Run on opened/synchronize for members, or when 'request preview' label is added
+            if (action === 'labeled' && label?.name === 'request preview') {
+              return 'yes';
+            } else if (action === 'opened' || action === 'synchronize' || action === 'reopened') {
+              return 'check-membership';
+            }
+            return 'no';
+
+      - uses: actions/github-script@v7
+        id: test-membership
+        if: steps.should-run.outputs.result == 'check-membership'
+        env:
+          AUTHOR: ${{ github.event.pull_request.user.login }}
+        with:
+          result-encoding: string
+          script: |
+            const author = process.env.AUTHOR;
+            if (author === 'jmdyck') return 'yes';
+            try {
+              const result = await github.request('GET /orgs/{org}/members/{username}', {
+                org: 'tc39',
+                username: author,
+                headers: {
+                  'X-GitHub-Api-Version': '2022-11-28'
+                }
+              });
+              return 'yes';
+            } catch (e) {
+              console.log({ author }, e);
+              return 'no';
+            }
+      - run: echo "${{steps.test-membership.outputs.result}}"
+
+  build:
+    name: 'publish PR preview'
+    runs-on: ubuntu-22.04
+    needs: check-membership
+    if: needs.check-membership.outputs.should-run == 'yes' || (needs.check-membership.outputs.should-run == 'check-membership' && needs.check-membership.outputs.result == 'yes')
+
+    permissions:
+      contents: write
+      pull-requests: write
+
+    steps:
+      - name: Remove 'request preview' label
+        if: github.event.action == 'labeled' && github.event.label.name == 'request preview'
+        uses: actions/github-script@v7
+        with:
+          script: |
+            await github.rest.issues.removeLabel({
+              owner: context.repo.owner,
+              repo: context.repo.repo,
+              issue_number: context.issue.number,
+              name: 'request preview'
+            });
+
+      - uses: actions/checkout@v4
+        with:
+          ref: ${{ github.event.pull_request.head.sha }}
+          repository: ${{ github.event.pull_request.head.repo.full_name }}
+
+      - name: Overwrite snapshot scripts with versions from main
+        run: |
+          git remote add upstream https://github.com/${{ github.event.pull_request.base.repo.full_name }}.git
+          git fetch upstream main
+          git checkout upstream/main -- scripts/insert-snapshot-warning.js scripts/deploy-github-pages.sh
+
+      - uses: ljharb/actions/node/install@7f214d8efdbdcefc96ad9689663ef387a195deec
+        name: 'nvm install lts/* && npm ci --no-audit'
+        env:
+          NPM_CONFIG_AUDIT: false
+        with:
+          node-version: lts/*
+          use-npm-ci: true
+      - run: npm run build-only
+      - run: node scripts/insert-snapshot-warning.js
+      - run: ./scripts/deploy-github-pages.sh --pr ${{ github.event.number }}
+        env:
+          GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
+      - id: get-preview-url
+        name: Get preview url
+        run: |
+          gh_pages_url="https://$(printf '%s' "$GITHUB_REPOSITORY" \
+            | sed 's#/#.github.io/#; s#^tc39.github.io/#tc39.es/#')"
+          echo "url=$gh_pages_url" >> $GITHUB_OUTPUT
+      - name: Post preview comment
+        uses: phulsechinmay/rewritable-pr-comment@v0.3.0
+        with:
+          GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
+          COMMENT_IDENTIFIER: tc39_pr_preview_comment
+          message: >
+            The rendered spec preview for this PR is available as a single page at
+            ${{ steps.get-preview-url.outputs.url }}/pr/${{ github.event.number }}
+            and as multiple pages at
+            ${{ steps.get-preview-url.outputs.url }}/pr/${{ github.event.number }}/multipage .