align the launcher grid options and icon sizes with the Pixel Launcher#51
Open
empratyush wants to merge 30 commits intoGrapheneOS:15-qpr2from
Open
align the launcher grid options and icon sizes with the Pixel Launcher#51empratyush wants to merge 30 commits intoGrapheneOS:15-qpr2from
empratyush wants to merge 30 commits intoGrapheneOS:15-qpr2from
Conversation
empratyush
force-pushed
the
dev-25-02-2025
branch
2 times, most recently
from
f5e884c to
021eb43
Compare
Member
Author
|
just noticed some files was missing new line at the end of the file. fixed it. |
|
Does this PR also include the 5x6 grid? :) |
Member
Author
|
It does include 6x5 (but only for tablet), same as pixel launcher. |
|
I understand. |
Change-Id: I8268a215257ae0e399c56ac8b44cdfdff8cc92a0
This space is usually empty on AOSP, so let's fill it with Settings. Change-Id: I33e925dd71350018e1859ba843cccf3cac95ad6d
The Pixel stock OS offers this option in ThemePicker. Change-Id: I059f81c24eeb42acdabdc29e0cc773830f778181
The default 13-point label size can barely fit any app names on modern phone form factors without ellipsizing. Reducing the size to 12 points allows us to fit most apps names, and upon visual inspection, it appears to be the same size as that of Pixel Launcher. Change-Id: I6ad63c14237f1f38c86ec02059b03896e5dd3a77
Fixes an issue where apps from "all apps" view can still be launched after search results are visible; which can cause a different app to be launched when tapped on a search result, or unexpected app launches when tapped on empty space (below search results). Testing: 1. open app drawer and search for anything 2. quickly tap on a search result or empty space 3. if tapped on one of the search results, correct app is launched; if tapped on the empty space, no app is launched
It opens the first party app source, which is not useful currently on GrapheneOS.
we don't have any devices in prod with this low display size and pixel launcher doesn't have 2x2 options for display size lower than 838:367.
previously 2x2 was effective on app drawer but this is not the case in pixel launcher so it break the existing user relying on 2x6 icons expectations in app drawer.
```
launcher:numAllAppsColumns="4"
launcher:numAllAppsRowsForCellHeightCalculation="4"
```
remove this or set it to 2 to restore 2x6 icon behaviour.
we don't have any devices in prod with this low display size and pixel launcher doesn't have 2x2 options for display size lower than 838:367.
previously 3x3 was effective on app drawer but this is not the case in pixel launcher so it break the existing user relying on3x6 icons expectations in app drawer.
```
launcher:numAllAppsColumns="4"
launcher:numAllAppsRowsForCellHeightCalculation="4"
```
remove this or set it to 3 to restore 2x6 icon behaviour.
`launcher:canBeDefault="true"` is removed so it won't be a consideration for default size when calculating default size on initial setup.
empratyush
force-pushed
the
dev-25-02-2025
branch
from
021eb43 to
c5ff1f4
Compare
Member
Author
|
rebased. |
Is there any hope this would be added to regular phones ? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
10 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes #4127