fix: resolve audit findings M-8, M-13, M-18#51
Merged
Conversation
M-18: Tighten governance action validation ranges - initiate-proposal-to-set-market-feature: u2-u23 → u2-u8 + u23 - initiate-proposal-to-set-market-state: u9-u22 → u9-u10 - Prevents creating proposals with mismatched action types that panic on execution M-8: Enforce minimum initial deposit for first LP depositor - Require >= 1000 units (0.001 USDC) on first deposit (total-assets == 0) - Mitigates share inflation attack vector (previously only blocked exactly 1) M-13: Add flash loan reentrancy guard - Boolean flag set before any external calls, cleared after all operations complete - Follows checks-effects-interactions pattern - Defense-in-depth (Clarity VM also prevents circular references) All 207 tests pass. No state-v1 modifications.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Continues V1.5 audit remediation (follows PRs #47–#50). Fixes 3 MEDIUM findings from the 2026-03-10 Claude Code Security Audit V2.
initiate-proposal-to-set-market-featurenarrowed from u2–u23 to u2–u8 + u23,initiate-proposal-to-set-market-statenarrowed from u9–u22 to u9–u10. Prevents creating proposals with mismatched action types thatunwrap-panicon execution.No
state-v1modifications. All 207 tests pass.Test plan
clarinet check— 36 contracts compilenpm test— 207/207 tests passgit diff)