Skip to content

GUB-75792: SDK to accept both HTTP and HTTPS requests. #22

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
Silambarasu05 wants to merge 4 commits into
base: develop
Choose a base branch
from
Draft

GUB-75792: SDK to accept both HTTP and HTTPS requests. #22

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
c5913b6
GUB-75792: update m_SafeServerURL method to handle IP addresses and e…
Silambarasu05 Jun 10, 2025
e8c2ce5
Add logging functionality to MediaManager and MediaVault classes
Silambarasu05 Jun 12, 2025
e8f8bed
Remove logging functionality from MediaManager and MediaVault classes
Silambarasu05 Jun 12, 2025
475f86b
Remove unnecessary blank line before m_SafeServerURL method in MediaV…
Silambarasu05 Jun 12, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 11 additions & 3 deletions Granicus.MediaManager.UserSDK/MediaManager.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -124,9 +124,17 @@ private string m_SafeServerURL(string Server)
{
if (!Server.StartsWith("https://") && !Server.StartsWith("http://"))
{
Server = "https://" + Server;
} else if(Server.StartsWith("http://") && !Server.Contains("mm.lvh.me")) {
Server = Server.Replace("http://","https://");
string serverHost = Server.Split(':')[0]; // Remove port if present
System.Net.IPAddress ipAddress;
bool isIp = System.Net.IPAddress.TryParse(serverHost, out ipAddress);
if (isIp)
{
Server = "http://" + Server;
}
else
{
Server = "https://" + Server;
}
}
if (!Server.EndsWith("/"))
{
Expand Down
13 changes: 11 additions & 2 deletions Granicus.MediaManager.UserSDK/MediaVault.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -201,9 +201,18 @@ protected override WebRequest GetWebRequest(Uri uri)
/// <returns></returns>
private string m_SafeServerURL(ServerInterfaceData Server)
{
if (!Server.Host.StartsWith("http://"))
if (!Server.Host.StartsWith("http://") && !Server.Host.StartsWith("https://"))
{
Server.Host = "http://" + Server.Host;
System.Net.IPAddress ipAddress;
bool isIp = System.Net.IPAddress.TryParse(Server.Host, out ipAddress);
if (isIp)
{
Server.Host = "http://" + Server.Host;
}
else
{
Server.Host = "https://" + Server.Host;
}
}
if (Server.Host.EndsWith("/"))
{
Expand Down