Skip to content

Conversation

@rk111
Copy link
Contributor

@rk111 rk111 commented Nov 5, 2025

Fix - update sdk cdn latest url

Summary by CodeRabbit

  • Chores
    • Updated banklink library reference to pin to version 1.0.4, ensuring consistent dependency loading across environments.

@coderabbitai
Copy link

coderabbitai bot commented Nov 5, 2025

Walkthrough

A script source URL in index.html is updated to pin the grailpay banklink library to a specific version (1.0.4) instead of loading an unversioned reference.

Changes

Cohort / File(s) Summary
Script version pinning
index.html
Script src updated from grailpay/banklink/index.min.js to grailpay/banklink@1.0.4/index.min.js to lock the library to version 1.0.4

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

  • Verify that version 1.0.4 is a valid and stable release of the grailpay banklink library
  • Confirm the new URL format is correct and accessible

Poem

🐰 A version pinned, so steady and true,
No more wild changes, just what we knew,
@1.0.4, we lock it down tight,
Banklinks shall flow, from morn until night! ✨

Pre-merge checks and finishing touches

✅ Passed checks (2 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately describes the main change: updating the SDK CDN URL from a generic endpoint to a pinned version (1.0.4).
✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

📜 Review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

Disabled knowledge base sources:

  • Linear integration is disabled by default for public repositories

You can enable these sources in your CodeRabbit configuration.

📥 Commits

Reviewing files that changed from the base of the PR and between 54e83c5 and 2404dc8.

📒 Files selected for processing (1)
  • index.html (1 hunks)
🔇 Additional comments (1)
index.html (1)

7-7: Clarify intent: PR title mentions "latest" but code pins to specific version 1.0.4.

The PR title suggests updating to track the latest SDK version, but the change pins to a specific version (1.0.4). This mismatch needs clarification:

  • If you want to always load the latest: use @grailpay/banklink@latest (with automatic updates)
  • If you want to pin to a stable version: 1.0.4 is appropriate, but update the PR description to reflect this intent

Which approach is intended?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants