feat(#2893): add open prop to WorkSideMenuGroup#3460
Conversation
✅ Deploy Preview for goa-design-2 ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
open prop to WorkSideMenuGroup
|
@copilot Add a menu group test to |
Added a |
|
@copilot The WorkSideMenuItem fires a bubbling |
Done in commit 5de79d4. |
|
@copilot Add |
Added
Both pages are wired into their respective routers and nav menus as |
ff4fff2 to
c7256c8
Compare
5f0f98e to
08f5afc
Compare
08f5afc to
f70a3f2
Compare
open prop to WorkSideMenuGroup
willcodeforcoffee
left a comment
There was a problem hiding this comment.
Everything looks good. I'm wondering though, could the watchPathChanges issue you had be caused because it is called twice in OnMount?
5d4549c to
148c9f1
Compare
|
Thanks, @willcodeforcoffee! I've amended my fix commit with only one call to |
Fix issues feat(#2893): add feat3398 sandbox pages for WorkSideMenuGroup open prop feat(#2893): auto-open group on _itemCurrent event from child item WorkSideMenuGroup now listens for the bubbling _itemCurrent event dispatched by WorkSideMenuItem when a child item becomes active, and automatically opens the group. Closes #2893 test(#2893): add WorkSideMenuGroup tests to browser spec feat(#2893): Add open prop to WorkSideMenuGroup Adds an `open` prop to the WorkSideMenuGroup component to control its initial expanded/collapsed state. User interaction still works after initialization. - Svelte: export let open: string = "false" + reactive $: _open - React: open?: boolean prop passed as string to web component - Angular: @input() open?: boolean bound via [attr.open] - Tests: added coverage for open prop across all three frameworks Closes #2893 Co-Authored-By: bdfranck <1479091+bdfranck@users.noreply.github.com>
148c9f1 to
1e8142f
Compare
willcodeforcoffee
left a comment
There was a problem hiding this comment.
👍 Great stuff, Benji! LGTM
Before (the change)
openstate was not publicly accessibleAfter (the change)
openpropertyTest scenarios
GoabxWorkSideMenuGroupwithopen={true}. Group should be open on mount.open={false}. Group should be closed on mount.openproperty. Group should be closed on mount.AI Workflow
This PR was created with the help of Copilot. Here's what I did:
Original Copilot prompt
openprop to WorkSideMenuGroup #3398💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.