Closed
Conversation
Add two new icons for V2 table sort headers: - chevron-expand: up/down chevrons for sortable columns - filter-lines: three horizontal lines for filter buttons Includes test pages in React and Angular playgrounds at /features/v2-icons
Bumps [lodash-es](https://github.com/lodash/lodash) from 4.17.21 to 4.17.23. - [Release notes](https://github.com/lodash/lodash/releases) - [Commits](lodash/lodash@4.17.21...4.17.23) --- updated-dependencies: - dependency-name: lodash-es dependency-version: 4.17.23 dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com>
Add documentation comments to component props across 67 components. These descriptions enable better IDE hints and support automated documentation generation.
- Remove @required tags from props without validateRequired() calls - Fix overstated "form submission" claims to "change events" - Remove incorrect "Auto-generated" claim from Accordion id prop - Fix "Reset skeleton shapes" to "Sets the skeleton shape" Addresses feedback from initial review
- Fix formatting: remove blank lines between JSDoc and exports - Standardize testid descriptions across components - Add @internal tag to version props (not for public docs) - Add @internal to multiselect in Dropdown (not exposed) - Add @required to Spinner size (no default value) - Fix inaccurate descriptions (Callout size, Dropdown icon/maxheight) - Add missing docs (DatePicker size, Button/IconButton/LinkButton actions) - Add default value to FileUploadInput maxfilesize description - Remove redundant // required comment in IconButton
- Add @internal to version props missed in round 2 (Badge, Button, Input, Tabs) - Add JSDoc to sub-component props (DropdownItem, MenuAction, TableSortHeader, TemporaryNotificationCtrl) - Remove blank line between props in Input.svelte
- Change @design-tokens alias to use npm package instead of sibling directory - Bump @abgov/design-tokens to ^2.0.0 - Fix CodeQL regex warnings in extract-code-parts.ts Written with help from Claude
- Add vite.ssr.noExternal config for @astrojs/react and @astrojs/mdx (fixes astro: protocol error in monorepo setup) Written with help from Claude
V2 tokens add --goa-dropdown-menu-margin which causes dropdown tests to fail when applied globally. Keep tokens aligned with their purpose: - Root uses V1 tokens (1.8.0) for component library tests - Docs uses V2 tokens (2.0.0) for docs site rendering Written with help from Claude
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.