Skip to content

Fix/parse response #146

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
gophergogo merged 7 commits into from
Dec 31, 2025
Merged

Fix/parse response #146

gophergogo merged 7 commits into from
Dec 31, 2025

Conversation

@gophergogo
Copy link
Collaborator

@gophergogo gophergogo commented Dec 31, 2025 •
edited
Loading

issue #144

gophergogo added 7 commits December 30, 2025 15:42
Add clarifying comment for ResponseResult variant usage (#144)
df77c27 
Document that tools and prompts use vector types directly in the
ResponseResult variant since they have simpler serialization needs.
Simplify server response serialization using ResponseResult variant (#…
b8a78c4 
…144)

Remove intermediate metadata conversion in handleListResources,
handleListTools, and handleListPrompts. Return results directly through
ResponseResult variant which supports ListResourcesResult, vector<Tool>,
and vector<Prompt> types.
Fix client response parsing to extract from ResponseResult variant (#144
938b45c 
)

Update listResources and listTools methods to properly extract results
from ResponseResult variant. listResources extracts ListResourcesResult
directly, while listTools extracts vector<Tool> and wraps it in
ListToolsResult.
Fix callTool response parsing to extract content and isError (#144)
2881b9f 
Parse the Metadata response from server to extract the content string
and isError flag. Convert content string to TextContent wrapped in
ExtendedContentBlock for proper CallToolResult structure.
Fix ResponseResult deserialization for tools without inputSchema (#144)
6649680 
The Tool type only requires "name" field, inputSchema is optional per
MCP spec. Changed detection logic from checking (name && inputSchema)
to (name && !uri) to distinguish tools from resources.
Fix callTool and getPrompt argument serialization (#144)
ca41bff 
Arguments were being flattened as "arguments.key" instead of nested
"arguments" object. Server looks for params["arguments"] which failed.
Now serialize arguments as JSON string to support nested object format
that server expects.

Also add debug output when callTool returns isError=true.
make format CPP code to apply clang-format (#144)
4de8dcd
@gophergogo gophergogo merged commit de1605f into main Dec 31, 2025
2 checks passed
@gophergogo gophergogo mentioned this pull request Dec 31, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@caleb2h caleb2h caleb2h approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@gophergogo @caleb2h