Fix/mcp client dispatcher deadlock #143
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…on (#142) Moved ListResourcesResult forward declaration before ResponseResult variant to allow it as a variant type. Added PaginatedResultBase for inheritance hierarchy.
…te (#142) Allow HTTP codec to send requests when in WaitingForResponse state, not just Idle. This enables proper HTTP/1.1 pipelining for batch requests. State machine transitions only occur from Idle state.
Fixed 10 methods that were blocking on future.get() inside dispatcher callbacks, causing deadlock since dispatcher thread processes read events. Methods fixed to use worker threads: - listResources, readResource, subscribeResource, unsubscribeResource - listTools, callTool - listPrompts, getPrompt - setLogLevel, createMessage Pattern: Post request to dispatcher (non-blocking), then wait for response on a detached worker thread instead of inside the callback.
added 4 commits
December 30, 2025 11:30
Reorder visitor_helper template parameters from <Variant, I> to <I, Variant> so recursive calls can specify just I+1 and let Variant be deduced from args.
…lization (#142) The ResponseResult variant includes ListResourcesResult but the serialization was missing a handler for it, causing compile errors when visiting the variant.
caleb2h
approved these changes
Dec 30, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.