This repository was archived by the owner on Sep 16, 2025. It is now read-only.
Open
Conversation
Added the use of useEffect hook to handle changes to the switchColour and isLarge props passed from the parent component. Changed the back arrow icon in the imports to the correct one. Added useRoute hook from @react-navigation/native to access the switchColour and isLarge props passed from the previous screen. Removed unused styles in the StyleSheet. Moved the styles constant inside the CreateAccount function for better encapsulation and readability. Replaced hard-coded styles with dynamic ones that take into account the isLarge and switchColour props. Removed the emailValidationText style as it is not used anymore. Added switchColour to the backgroundColor of the button style, depending on its value. Updated the onPress function of the Continue button to pass the switchColour and isLarge props to the next screen.
deegle0-0
reviewed
Apr 28, 2023
Contributor
deegle0-0
left a comment
deegle0-0
left a comment
There was a problem hiding this comment.
Hey Ming there is this error in the code. Please make the changes when you can and resubmit
Contributor
|
Also please upload your package.json when you upload your file changes. run the code on your emulator, make sure it works and then reupload |
deegle0-0
suggested changes
Apr 29, 2023
Contributor
deegle0-0
left a comment
deegle0-0
left a comment
There was a problem hiding this comment.
Hello, The whole screen is invisible now. Please try to run on your emulator and submit
Android.Emulator.-.Pixel_5_API_33_5554.2023-04-29.16-09-14.mp4
Please also make note!
Upload your package.json file and your package-lock.json as well. For some reason the ones you are uploading dont have axios, email-validator dependencies which I have to manually install.
When you run the files you will have to install the dependencies. Please run the page on emulator before you push again.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added the use of useEffect hook to handle changes to the switchColour and isLarge props passed from the parent component. Changed the back arrow icon in the imports to the correct one. Added useRoute hook from @react-navigation/native to access the switchColour and isLarge props passed from the previous screen. Removed unused styles in the StyleSheet.
Moved the styles constant inside the CreateAccount function for better encapsulation and readability. Replaced hard-coded styles with dynamic ones that take into account the isLarge and switchColour props. Removed the emailValidationText style as it is not used anymore. Added switchColour to the backgroundColor of the button style, depending on its value. Updated the onPress function of the Continue button to pass the switchColour and isLarge props to the next screen.