This repository was archived by the owner on Oct 27, 2022. It is now read-only.
fix default build mechanism priority for jib (address #7)#28
Open
SaketramDurbha wants to merge 4 commits intoGoogleCloudPlatform:masterfrom
Open
fix default build mechanism priority for jib (address #7)#28SaketramDurbha wants to merge 4 commits intoGoogleCloudPlatform:masterfrom
SaketramDurbha wants to merge 4 commits intoGoogleCloudPlatform:masterfrom
Conversation
SaketramDurbha
requested review from
danielylee01,
dmahugh,
jsimonweb and
kurtisvg
kurtisvg
approved these changes
Aug 18, 2020
SaketramDurbha
requested review from
grayside,
kurtisvg and
tritone
and removed request for
tritone
kurtisvg
approved these changes
Aug 20, 2020
added 4 commits
August 22, 2020 16:54
- add more info about reasonable defaults in README.md
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR addresses issue #7 in part.
For all Java-based samples (
pom.xmlin the sample's root directory), we're going to use Jib, regardless of whether or not the sample also has aDockerfileincluded in its root directory.If we want, we can also include a
—no-jibflag here that would force the program to usegcloud builds submitfor all samples.