Use caching to speed up image build validation

[linsword13]

No description provided.

[gemini-code-assist]

Summary of Changes

Hello @linsword13, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request significantly optimizes the image build validation process within Cloud Build by implementing Docker layer caching. By configuring the build steps to utilize previously built images as cache sources, the time required for both APT and YUM-based image builds will be substantially reduced. This enhancement aims to accelerate the feedback loop for developers and improve the overall efficiency of the CI/CD pipeline.

Highlights

• Docker Build Caching for APT Images: The Cloud Build configuration for APT-based Docker images now includes the --cache-from argument, leveraging a pre-existing image in Google Artifact Registry as a cache source to speed up builds.
• Docker Build Caching for YUM Images: Similarly, the Cloud Build configuration for YUM-based Docker images has been updated to use the --cache-from argument, pulling cache layers from a specified image in Google Artifact Registry.
• New Substitution Variables: New substitution variables (_BASE_IMG_APT, _BASE_VER_APT, _BASE_IMG_YUM, _BASE_VER_YUM) have been introduced to parameterize the base image names and versions used in the cache-from references, making the configuration more flexible and maintainable.

Changelog

• share/ramble/cloud-build/ramble-pr-image-builds.yaml
  • Added --cache-from argument to the docker build command for the Dockerfile-apt build step, referencing a specific image in Google Artifact Registry.
  • Added --cache-from argument to the docker build command for the Dockerfile-yum build step, referencing a specific image in Google Artifact Registry.
  • Introduced new substitution variables: _BASE_IMG_APT, _BASE_VER_APT, _BASE_IMG_YUM, and _BASE_VER_YUM to define base image details for caching.

Activity

• No specific activity (comments, reviews, progress updates) has been recorded for this pull request yet.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request introduces caching for Docker image builds to speed up the process, which is a great enhancement. The changes add --cache-from flags to the build steps. My review includes suggestions to make this configuration more robust by explicitly passing the base image and version as build arguments. This avoids relying on default values within the Dockerfiles and prevents potential mismatches between the build environment and the cache source, improving maintainability.

[gemini-code-assist]

To improve maintainability and prevent potential inconsistencies, it's better to explicitly pass BASE_IMG and BASE_VER as build arguments rather than relying on the defaults in the Dockerfile. This ensures that the image is built with the same base image and version that are used to tag the cache.

      - 'us-central1-docker.pkg.dev/$PROJECT_ID/ramble-repo/ramble-${_BASE_IMG_APT}-${_BASE_VER_APT}-spack${_SPACK_REF}-python${_PYTHON_VER}:latest'
      - '--build-arg'
      - 'BASE_IMG=${_BASE_IMG_APT}'
      - '--build-arg'
      - 'BASE_VER=${_BASE_VER_APT}'

[gemini-code-assist]

To improve maintainability and prevent potential inconsistencies, it's better to explicitly pass BASE_IMG and BASE_VER as build arguments rather than relying on the defaults in the Dockerfile. This ensures that the image is built with the same base image and version that are used to tag the cache.

      - 'us-central1-docker.pkg.dev/$PROJECT_ID/ramble-repo/ramble-${_BASE_IMG_YUM}-${_BASE_VER_YUM}-spack${_SPACK_REF}-python${_PYTHON_VER}:latest'
      - '--build-arg'
      - 'BASE_IMG=${_BASE_IMG_YUM}'
      - '--build-arg'
      - 'BASE_VER=${_BASE_VER_YUM}'