Surface CollectorDaemonSetExists status condition on OperatorConfig #1854
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
Re-added GenerationChangedPredicate to DaemonSet watcher to avoid noise from status updates (while still catching deletions). Added GenerationChangedPredicate to OperatorConfig watcher to prevent feedback loops from status updates.
Address CodeRabbit feedback: initialize condition status to Unknown instead of True, so that on unexpected errors (network issues, RBAC), the condition reflects uncertainty rather than falsely indicating the DaemonSet exists.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1830
Summary
Adds a
CollectorDaemonSetExistsstatus condition toOperatorConfigto surface when the collector DaemonSet is missing.Problem
When the collector DaemonSet (
gmp-system/collector) is deleted, the operator logs a warning but returns success without surfacing any status condition. This leaves metrics collection silently broken with no way for users to detect the outage via the API.Solution
CollectorDaemonSetExistscondition toOperatorConfig.StatusTruewhen the DaemonSet exists,Falsewith reasonDaemonSetMissingwhen not foundUnknownto handle unexpected API errors correctlyThis only checks DaemonSet existence, not pod readiness, and does not auto recreate deleted DaemonSets