release/0.17[BACKPORT]: feat: enable against GCM tests for e2e #1848
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We plan to add more tests around this path, so checking if it's safe to enable or we need to do bit more work to make it per CI. We already have secret for other GCM e2e tests. Signed-off-by: bwplotka <bwplotka@google.com>
Collaborator
Author
|
Some other setup is failing. I am not sure this will catch the issue due to similar reasons as prometheus-engine/e2e/crd_validation_test.go Line 248 in 9b61240 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backporting b7b5b8f#diff-bd5897af030ce203375c9805d24a4f8aac44c4f879d60b6a1296931d6bf67e1e to try to repro an issue.