Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion authenticating-users/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@
"google-auth-library": "^8.0.0"
},
"devDependencies": {
"mocha": "^9.0.0",
"mocha": "^11.0.0",
"supertest": "^6.0.0"
}
}
2 changes: 1 addition & 1 deletion background/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@
"body-parser": "^1.18.3",
"child_process": "^1.0.2",
"@google-cloud/functions": "^3.0.0",
"mocha": "^9.0.0",
"mocha": "^11.0.0",
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

critical

This update to Mocha v11 introduces a significant breaking change: it requires Node.js version 18.0.0 or higher. The previous version, v9, supported much older Node.js versions.

Your project appears to use older Node.js runtimes. For example, the integration tests for the background sample deploy a Google Cloud Function with the nodejs10 runtime (background/test/app.test.js line 38).

// background/test/app.test.js:38
cp.execSync(
  `gcloud functions deploy translate-${uniqueID} --runtime nodejs10 ...`
);

Merging this change without updating your Node.js environments (both for CI and for the samples themselves) will likely cause the build to fail during npm install. This is a critical issue that needs to be addressed. Please verify and update the Node.js versions used across this repository to be compatible with Mocha v11.

"node-fetch": "^2.6.0",
"uuid": "^9.0.0",
"wait-on": "^7.0.0"
Expand Down
2 changes: 1 addition & 1 deletion bookshelf/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@
"pug": "^3.0.0"
},
"devDependencies": {
"mocha": "^9.0.0",
"mocha": "^11.0.0",
"supertest": "^6.0.0"
}
}
2 changes: 1 addition & 1 deletion gce/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@
"express": "^4.16.3"
},
"devDependencies": {
"mocha": "^9.0.0",
"mocha": "^11.0.0",
"uuid": "^9.0.0",
"chai": "^4.2.0",
"node-fetch": "^2.6.0"
Expand Down
2 changes: 1 addition & 1 deletion sessions/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@
"express-session": "^1.16.2"
},
"devDependencies": {
"mocha": "^9.0.0",
"mocha": "^11.0.0",
"supertest": "^6.0.0"
}
}