feat(evaluate): add custom runner configs to lower evalbench parallelism#65
Merged
helloeve merged 1 commit intofeat/hill-climbingfrom Apr 5, 2026
Merged
Conversation
There was a problem hiding this comment.
Code Review
This pull request introduces parallelism tuning for the evaluator by adding a runners section to the generated run configuration, setting eval_runners and sqlgen_runners to 2. Feedback suggests that these hardcoded values should be made configurable or defined as constants to improve flexibility for users with different quota limits and to enhance code maintainability.
helloeve
approved these changes
Apr 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
eval_runners: 2andsqlgen_runners: 2in the generatedrun_config.yaml.Why
To throttle concurrent requests and prevent Vertex AI quota exhaustion during multi-threaded execution.
This will increase the running time to around 4 minutes with our current settings with a high success rate.