feat: add Spanner and CloudSQL support to value search generation#50
feat: add Spanner and CloudSQL support to value search generation#50hardikgu23 merged 8 commits intomainfrom
Conversation
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request significantly enhances the system's compatibility by extending support to MySQL and Google SQL (Spanner) databases. The changes involve updating the user interaction prompts to dynamically infer database engines and collect necessary engine-specific parameters, ensuring that the value search generation process can adapt to the unique requirements of these new database types. This expansion allows for a broader range of data sources to leverage the value search capabilities. Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request significantly expands the targeted value search functionality by supporting additional database types: PostgreSQL, MySQL, and Spanner. The workflow has been updated to infer the database engine from the provided database type, and new engine-specific parameters have been introduced for Spanner and MySQL. Corresponding SQL templates for GOOGLE_SQL and MYSQL dialects have been added, and the generate_value_searches function now handles these new parameters. Review feedback suggests adding a final newline to mcp/prompts/targeted_value_search.py for PEP 8 compliance, including the table name in the columns field for new GOOGLE_SQL and MYSQL templates for consistency, and simplifying the MySQL TRIGRAM_STRING_MATCH and SEMANTIC_STRING_MATCH templates by removing redundant outer SELECT * FROM (...) AS wrapped_query wrappers.
wangauone
left a comment
There was a problem hiding this comment.
Update the PR title and desc to the format of https://www.conventionalcommits.org/en/v1.0.0/. So the release automation pipeline can help us bump the version automatically after merged.
🤖 I have created a release *beep* *boop* --- ## [0.4.3](v0.4.2...v0.4.3) (2026-04-02) ### Features * add Spanner and CloudSQL support to value search generation ([#50](#50)) ([5a56582](5a56582)) * **value-search:** extend support to Spanner, MySQL, and Postgres ([5a56582](5a56582)) ### Bug Fixes * **build:** disable strip and upx to resolve windows pyinstaller crash ([#52](#52)) ([e07c52b](e07c52b)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>
feat(value-search): extend support to Spanner, MySQL, and Postgres
This PR expands the value search generation feature to support additional database engines.
Changes included:
Previously, this feature was only supported for AlloyDB.