Skip to content

Conversation

@yamigil
Copy link

@yamigil yamigil commented Dec 19, 2024

Added the Ads_Analytics Pipeline

@google-cla
Copy link

google-cla bot commented Dec 19, 2024

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@iht
Copy link
Member

iht commented Jan 1, 2025

Hi @yamigil,

Please remove all the .DS_Store files in this PR.

Your Java pipeline is using Maven, and the automated build and checks in this repo assume that Java pipelines use gradle. Adapting your code to using gradle should be easy, you need to copy some files and edit the names (package and class name in the build.gradle file, maybe some dependencies if you are using specific dependencies).

Alternatively, we could try adding support for Maven in the automated build too, but you would need to update your Maven settings to use spotless and errorprone, so we apply the same validations as we do with gradle.

Please let me know what is your preferred choice (switch to Gradle or stay in Maven).

Thanks for sending this PR!

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove this file

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove this file

@yamigil
Copy link
Author

yamigil commented Jan 7, 2025

Let me change it to Gradle and get back to you

@yamigil yamigil requested a review from iht April 21, 2025 19:44
@yamigil
Copy link
Author

yamigil commented Apr 24, 2025

Hi Israel, the validation error I'm getting is not part of my pipeline:

Traceback (most recent call last):
  File "/home/runner/work/dataflow-solution-guides/dataflow-solution-guides/pipelines/cdp/setup.py", line 18, in <module>
    from setuptools import setup, find_packages
ModuleNotFoundError: No module named 'setuptools'

How can we get past it?

Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants